Bug Qt-celestia SVN 5142

[Boux]

Hi all,
Following some recent changes to the QT version source code, qt-celestia will no longer build (SVN 5137-->5142).
The compiler outputs an error that points to line 162 of qtappwin.ccp.
Changing CONFIG_DATA_DIR to a QString like this:

Code: Select all

QString celestia_data_dir = "CONFIG_DATA_DIR";

seems to fix the bug and qt-celestia will build.

[ajtribick]

So it seems that fixing it so that you don't have to cd to the source code directory on Linux to run the executable breaks it on Windows (assuming this based on the operating systems listed in your sig - more details of what you are using to compile would be useful please)...

Aaargh.

[John Van Vliet]

--- edit ---

[Boux]

ajtribick
yes, this is correct, OS is Windows Vista 64.
IDE is VC Express 2008 and QT environment is 4.5.3.
I guess this is all about the black art of programming, hehe, making an improvement or killing one bug somewhere will just make a new bug pop up elsewhere...

[t00fri]

So it seems that fixing it so that you don't have to cd to the source code directory on Linux to run the executable breaks it on Windows (assuming this based on the operating systems listed in your sig

The CONFIG_DATA_DIR error also persists if r5143 is built with Qt-creator 2.0.94 and QT 4.7.2 under OpenSuSE 11.2!

Fridger

PS:
using precisely these steps:

1) a clean checkout of r5143
2) > touch config.h (i.e no autotools used)
3) compile under qtcreator

[Vincent]

I get the same error on Win XP 32 bits with Qt4.6.2 and qmaking celestia.pro.

[ajtribick]

Ok so it looks like this breaks it for pretty much everyone. Sorry about that, will try to get a few more test configurations set up to avoid this in future. I guess we should back this one out?

Incidentally it would be nice to have a few more participants on the dev list doing more testing of patches, rather than waiting until things break (this one's been on the list for a couple of months now)...

[John Van Vliet]

--- edit ---