Build error QT-Celestia

Report bugs, bug fixes and workarounds here.
Topic author
Boux
Posts: 435
Joined: 25.08.2004
With us: 20 years 3 months
Location: Brittany, close to the Ocean

Build error QT-Celestia

Post #1by Boux » 18.04.2010, 12:15

Looks like there is a syntax error in line 63 of xbel.ccp source:

Code: Select all

raiseError(QString(_("Not an XBEL version 1.0 file.")));

The underscore "_" makes the compiler complain about an unknown identifier and abort building.

Changing the line to:

Code: Select all

raiseError(QString("Not an XBEL version 1.0 file."));

seems to fix it.
Intel core i7 3770 Ivy Bridge @ 4.4 GHz -16 GB ram - 128 GB SSD cache - AMD Radeon 7970 3 GB o'clocked - Windows 7 64 Ultimate / Linux Kubuntu

Vincent
Developer
Posts: 1356
Joined: 07.01.2005
With us: 19 years 11 months
Location: Nancy, France

Re: Build error QT-Celestia

Post #2by Vincent » 18.04.2010, 12:30

Hi Boux,

Thanks for the report.
I recently added i18n support through gettext to the qt4 version of Celestia.
The _() macro is defined in util.h and is used to mark all strings that need a translation.

The compilation error should be fixed by adding the following include to xbel.ccp:

Code: Select all

#include "celutil/util.h"


I'll commit the fix to SVN soon.
@+
Vincent

Celestia Qt4 SVN / Celestia 1.6.1 + Lua Edu Tools v1.2
GeForce 8600 GT 1024MB / AMD Athlon 64 Dual Core / 4Go DDR2 / XP SP3

Topic author
Boux
Posts: 435
Joined: 25.08.2004
With us: 20 years 3 months
Location: Brittany, close to the Ocean

Re: Build error QT-Celestia

Post #3by Boux » 18.04.2010, 12:48

Salut Vincent!
OK, I see what happened now.
Thanks
Intel core i7 3770 Ivy Bridge @ 4.4 GHz -16 GB ram - 128 GB SSD cache - AMD Radeon 7970 3 GB o'clocked - Windows 7 64 Ultimate / Linux Kubuntu

Vincent
Developer
Posts: 1356
Joined: 07.01.2005
With us: 19 years 11 months
Location: Nancy, France

Re: Build error QT-Celestia

Post #4by Vincent » 18.04.2010, 13:19

Boux wrote:Salut Vincent!
OK, I see what happened now.
Thanks
Boux, you're welcome.
This is fixed in SVN now.

Attached is an updated version of fr.po that provides
a 100% translated qt4 version for testing. :)
@+
Vincent

Celestia Qt4 SVN / Celestia 1.6.1 + Lua Edu Tools v1.2
GeForce 8600 GT 1024MB / AMD Athlon 64 Dual Core / 4Go DDR2 / XP SP3

Avatar
t00fri
Developer
Posts: 8772
Joined: 29.03.2002
Age: 22
With us: 22 years 8 months
Location: Hamburg, Germany

Re: Build error QT-Celestia

Post #5by t00fri » 18.04.2010, 15:26

I had also spotted that _( ) bug yesterday. The remedy was obvious. Now (rev. 5013) everything compiles again without complaints.

Fridger
Image


Return to “Bugs”