What is the % used for ?

General discussion about Celestia that doesn't fit into other forums.
Avatar
Topic author
Cham M
Posts: 4324
Joined: 14.01.2004
Age: 60
With us: 20 years 10 months
Location: Montreal

What is the % used for ?

Post #1by Cham » 08.03.2007, 08:02

I just discovered an option I didn't knew, after all this time passed with Celestia ! Shift-5 = %. It changes the colors of all the stars. Why ? What is this ? Apparently, it's not even declared in the menus.

The blue stars gets a stronger blue tone, while the red and orange stars gets a stronger tone of color. I'm puzzled ! :oops:
"Well! I've often seen a cat without a grin", thought Alice; "but a grin without a cat! It's the most curious thing I ever saw in all my life!"

Avatar
t00fri
Developer
Posts: 8772
Joined: 29.03.2002
Age: 22
With us: 22 years 7 months
Location: Hamburg, Germany

Post #2by t00fri » 08.03.2007, 09:02

ChangeLog:

* Bound % key to toggle between star color tables

cf. starcolors.cpp
in src/celengine directory.

and the key definition in src/celestia/celestiacore.cpp

Code: Select all

 case '%':
        {
            const ColorTemperatureTable* current =
                renderer->getStarColorTable();
            if (current == GetStarColorTable(ColorTable_Enhanced))
            {
                renderer->setStarColorTable(GetStarColorTable(ColorTable_Blackbody_D65));
            }
            else if (current == GetStarColorTable(ColorTable_Blackbody_D65))
            {
                renderer->setStarColorTable(GetStarColorTable(ColorTable_Enhanced));
            }
            else
            {
                // Unknown color table
            }
        }
        break;


Bye Fridger
Image

Avatar
Topic author
Cham M
Posts: 4324
Joined: 14.01.2004
Age: 60
With us: 20 years 10 months
Location: Montreal

Post #3by Cham » 08.03.2007, 18:25

This code doesn't explain anything to me. :evil:
"Well! I've often seen a cat without a grin", thought Alice; "but a grin without a cat! It's the most curious thing I ever saw in all my life!"

buggs_moran
Posts: 835
Joined: 27.09.2004
With us: 20 years 1 month
Location: Massachusetts, USA

Post #4by buggs_moran » 08.03.2007, 18:36

One is for pure blackbody colors based on star type and one is for enhanced coloring if I remember correctly... but I don't know what is being enhanced. :?
Homebrew:
WinXP Pro SP2
Asus A7N8X-E Deluxe
AMD Athlon XP 3000/333 2.16 GHz
1 GB Crucial RAM
80 GB WD SATA drive
ATI AIW 9600XT 128M

Avatar
Topic author
Cham M
Posts: 4324
Joined: 14.01.2004
Age: 60
With us: 20 years 10 months
Location: Montreal

Post #5by Cham » 08.03.2007, 18:41

buggs_moran wrote:One is for pure blackbody colors based on star type and one is for enhanced coloring if I remember correctly... but I don't know what is being enhanced. :?


That's what I'm wondering. What is the enhanced colors actually means ? Is this just a way to reveal the color differences between stars ?
"Well! I've often seen a cat without a grin", thought Alice; "but a grin without a cat! It's the most curious thing I ever saw in all my life!"

Avatar
t00fri
Developer
Posts: 8772
Joined: 29.03.2002
Age: 22
With us: 22 years 7 months
Location: Hamburg, Germany

Post #6by t00fri » 08.03.2007, 18:43

buggs_moran wrote:One is for pure blackbody colors based on star type and one is for enhanced coloring if I remember correctly... but I don't know what is being enhanced. :?


Right. The two color tables may be explicitly inspected in src/celengine/starcolors.cpp

The above code I thought should be readable without being a C++ Guru:

It says: in case of the '%' key being pushed:

-- if the current color table = ColorTable_Enhanced, then switch to ColorTable_Blackbody_D65

--if the current color table = ColorTable_Blackbody_D65,
then switch to ColorTable_Enhanced

No other action possible after hitting '%'.

Was this so hard??

Bye Fridger
Image

Avatar
Topic author
Cham M
Posts: 4324
Joined: 14.01.2004
Age: 60
With us: 20 years 10 months
Location: Montreal

Post #7by Cham » 08.03.2007, 18:46

t00fri wrote:Was this so hard??

Bye Fridger


Fridger, don't you understand that this code doesn't answer the question at all ? What does the second table means ?? Was it that hard to understand the question in the first place ?
"Well! I've often seen a cat without a grin", thought Alice; "but a grin without a cat! It's the most curious thing I ever saw in all my life!"

Avatar
t00fri
Developer
Posts: 8772
Joined: 29.03.2002
Age: 22
With us: 22 years 7 months
Location: Hamburg, Germany

Post #8by t00fri » 08.03.2007, 18:50

Cham wrote:
t00fri wrote:Was this so hard??

Bye Fridger

Fridger, don't you understand that this code doesn't answer the question at all ? What does the second table means ?? Was it that hard to understand the question in the first place ?


Sorry this was NOT the question you asked when I wrote the above answer! At that point you had just stated

Cham wrote:This code doesn't explain anything to me.


My previous post was just an answer to this and only this point. I had also told you the files (starcolors.cpp), where you can take your time and study the differences in the color assignments.
That's all I can tell you. Chris entered these two tables.

Bye Fridger
Image

Avatar
Topic author
Cham M
Posts: 4324
Joined: 14.01.2004
Age: 60
With us: 20 years 10 months
Location: Montreal

Post #9by Cham » 08.03.2007, 18:52

t00fri wrote:That's all I can tell you. Chris entered these two tables.


Then you don't know yourself what the second table is. There's a mystery to solve here :wink:
"Well! I've often seen a cat without a grin", thought Alice; "but a grin without a cat! It's the most curious thing I ever saw in all my life!"

Avatar
t00fri
Developer
Posts: 8772
Joined: 29.03.2002
Age: 22
With us: 22 years 7 months
Location: Hamburg, Germany

Post #10by t00fri » 08.03.2007, 18:59

Cham wrote:
t00fri wrote:That's all I can tell you. Chris entered these two tables.

Then you don't know yourself what the second table is. There's a mystery to solve here :wink:


I dont know /exactly/ what the enhanced color table means. My common sense tells me --knowing how a blackbody color map looks like-- that enhanced probably means enhanced colors relative to blackbody.

If I was interested in that point myself, I would just inspect the color map in starcolors.cpp relative to the blackbody table. It's all human readable and all RGB color assignments are specified there.

Another heuristic way would be to find out empirically how "enhanced" looks like by trying it out in Celestia, knowing the action of the % key toggles between "enhanced" and "blackbody". What else would one want to know??

There are plenty of such colormaps for stars in the net. It's probably one such example. Chris did not comment about this in more detail in the dev list.

Bye Fridger
Image

ajtribick
Developer
Posts: 1855
Joined: 11.08.2003
With us: 21 years 3 months

Post #11by ajtribick » 08.03.2007, 19:05

It would be good to have some kind of message displayed on the key press to tell you which table is which!

Avatar
Topic author
Cham M
Posts: 4324
Joined: 14.01.2004
Age: 60
With us: 20 years 10 months
Location: Montreal

Post #12by Cham » 08.03.2007, 19:07

The problem is, looking at numbers wont tell me anything special, except that the numbers are different in the tables used. What is the "physics" for the second table ? What information does it contains ?

I have the feeling there is none ! It's just a way to heighten the contrasts in colors, but I may be dead wrong here.

chaos syndrome wrote:It would be good to have some kind of message displayed on the key press to tell you which table is which!


Yes, I agree. A text message should be displayed.

Chris, please ?
"Well! I've often seen a cat without a grin", thought Alice; "but a grin without a cat! It's the most curious thing I ever saw in all my life!"

Avatar
t00fri
Developer
Posts: 8772
Joined: 29.03.2002
Age: 22
With us: 22 years 7 months
Location: Hamburg, Germany

Post #13by t00fri » 08.03.2007, 19:13

chaos syndrome wrote:It would be good to have some kind of message displayed on the key press to tell you which table is which!


Certainly ;-)

But one can really see what the enhanced table looks like. Go to some region with many stars. Adjust ' ] ' maximal and switch to "scaled disks" (CTRL+S) to have a clearer view. Then toggle between the 2 color tables and you will see --as expected-- that in "enhanced" mode red and blue stars appear with much more saturated colors.

So I don't see here much of a mystery...

The only remaining question could be where Chris copied this enhanced table from ?

Bye Fridger
Image

ElChristou
Developer
Posts: 3776
Joined: 04.02.2005
With us: 19 years 9 months

Post #14by ElChristou » 08.03.2007, 19:20

chaos syndrome wrote:It would be good to have some kind of message displayed on the key press to tell you which table is which!


Yep, I asked this a long time ago in the dev list, but as nothing came out I suppose it's not a so important feature... :?
Image

Avatar
Topic author
Cham M
Posts: 4324
Joined: 14.01.2004
Age: 60
With us: 20 years 10 months
Location: Montreal

Post #15by Cham » 08.03.2007, 19:21

t00fri wrote:Then toggle between the 2 color tables and you will see --as expected-- that in "enhanced" mode red and blue stars appear with much more saturated colors.

So I don't see here much of a mystery...


Fridger, this is obvious and I already tested this as soon as I discovered the option, but it doesn't explain anything to me. My question is the information content of this mode. What does the "enhanced" colors actually means ? Why two modes of colors ? Which one is the accurate mode for the human eye ? (probably the first, but ...).
"Well! I've often seen a cat without a grin", thought Alice; "but a grin without a cat! It's the most curious thing I ever saw in all my life!"

Avatar
t00fri
Developer
Posts: 8772
Joined: 29.03.2002
Age: 22
With us: 22 years 7 months
Location: Hamburg, Germany

Post #16by t00fri » 08.03.2007, 19:24

ElChristou wrote:
chaos syndrome wrote:It would be good to have some kind of message displayed on the key press to tell you which table is which!

Yep, I asked this a long time ago in the dev list, but as nothing came out I suppose it's not a so important feature... :?


That's also my interpretation. Chris was experimenting really A LOT, when trying to improve his new star rendering. So essentially for testing purposes, he implemented these two alternative color tables, one being a classical blackbody, the other providing more intensive colors. As I said I knew a whole web site specializing on offering such different star color tables.

Bye Fridger
Image

chris
Site Admin
Posts: 4211
Joined: 28.01.2002
With us: 22 years 9 months
Location: Seattle, Washington, USA

Post #17by chris » 08.03.2007, 19:27

ElChristou wrote:
chaos syndrome wrote:It would be good to have some kind of message displayed on the key press to tell you which table is which!

Yep, I asked this a long time ago in the dev list, but as nothing came out I suppose it's not a so important feature... :?


Sorry . . . You should file a bug on the SourceForge tracker so that the request doesn't get lost. It's a very easy fix, I just need to remember to do it when I'm working on the Celestia code.

--Chris

Avatar
Topic author
Cham M
Posts: 4324
Joined: 14.01.2004
Age: 60
With us: 20 years 10 months
Location: Montreal

Post #18by Cham » 08.03.2007, 19:29

If there's no informational content in this mode (like what I currently believe), then it should be removed. It's puzzling to the user. At first, when I discovered it last night, I thought to myself that it was surely telling something (despite the absence of message).
"Well! I've often seen a cat without a grin", thought Alice; "but a grin without a cat! It's the most curious thing I ever saw in all my life!"

Avatar
t00fri
Developer
Posts: 8772
Joined: 29.03.2002
Age: 22
With us: 22 years 7 months
Location: Hamburg, Germany

Post #19by t00fri » 08.03.2007, 19:32

Cham wrote:The problem is, looking at numbers wont tell me anything special, except that the numbers are different in the tables used. What is the "physics" for the second table ? What information does it contains ?

I have the feeling there is none ! It's just a way to heighten the contrasts in colors, but I may be dead wrong here.



A color table in this context (as clearly commented in starcolors.cpp) maps the star surface temperatures to RGB colors. Obviously an INFINITY of such maps is possible and most are not even distinguished physically. Different maps may even account for different monitor characteristics if you want.

In stars.cpp there are the corresponding maps that associate the star luminosity classes with their surface temperatures. So for each luminosity class specified e.g. in the HIP catalog entry, eventually one associates a RGB color on the monitor. How this looks like, is specified by the respective color table.

Bye Fridger
Image

Avatar
Topic author
Cham M
Posts: 4324
Joined: 14.01.2004
Age: 60
With us: 20 years 10 months
Location: Montreal

Post #20by Cham » 08.03.2007, 19:35

Then the second table may be usefull after all, depending on the monitor used. Actually, I've found that the enhanced colors are pretty on my monitor, despite that they appears to be a bit too strong for my taste (not very realistic).
"Well! I've often seen a cat without a grin", thought Alice; "but a grin without a cat! It's the most curious thing I ever saw in all my life!"


Return to “Celestia Users”