GTK+ Front-End Refactored.

[suwalski]

Ah, I've finally managed to reproduce it on a Debian install at work. I'll look into this, but there are no errors or warnings or anything.

I don't add the labels, that happens inside of GTK. And the boxes definitely work.

So, I don't know what's up with this.

[suwalski]

I've also managed to find another place where this same bug exists within Gnome, showing that it's a toolkit bug:

If you start the "Menus and Toolbar Preferences" (gnome-ui-properties), on systems where the text does not appear in Celestia also shows no text in the preview widget there. This is especially apparent when the drop-down is set to "text only".

[suwalski]

It's confirmed. I chatted with the GTK head developer and it was fixed somewhere between 2.6 and 2.8.

Here's an excerpt:

Dec 15 10:21:59 <pat> anyone running clean sarge?
Dec 15 10:22:07 <pat> I get no labels on a checkbox that's been proxied
Dec 15 10:22:36 <pat> and you can see this same bug in gnome-ui-properties
Dec 15 10:22:41 <pat> the preview doesn't show the labels
Dec 15 10:22:43 <muntyan> pat: i have sarge
Dec 15 10:23:01 <muntyan> pat: if you've got some code, i can test it
Dec 15 10:23:02 <pat> muntyan: this is only in gtk 2.6 that is with stock debian
Dec 15 10:23:11 <muntyan> pat: yes, gtk-2.6
Dec 15 10:23:12 <pat> muntyan: if you're running gnome, just open gnome-ui-properties
Dec 15 10:23:18 <muntyan> i'm not
Dec 15 10:23:23 <pat> oh.
Dec 15 10:23:32 <muntyan> but i have that
Dec 15 10:23:37 <muntyan> looks fine
Dec 15 10:24:02 <muntyan> ah
Dec 15 10:24:10 <muntyan> pat: labels on toolbat buttons?
Dec 15 10:24:12 <pat> yes
Dec 15 10:24:18 <pat> and anyt GtkAction items that are proxies
Dec 15 10:24:30 <pat> Actually, I don't know about the "that a re proxies" part
Dec 15 10:24:36 <muntyan> pat: yes, toolbar in gnome-ui-properties doesn't have text
Dec 15 10:24:45 <pat> and if you set it to "text only"
Dec 15 10:24:48 <muntyan> pat: i have no idea about actions and proxies, though
Dec 15 10:24:51 <pat> you get "zilch"?
Dec 15 10:25:02 <muntyan> pat: no, i get "empty"
Dec 15 10:25:09 <muntyan> pat: hard to type in russian
Dec 15 10:25:09 <pat> haha, me too.
Dec 15 10:25:11 <muntyan>

... and, more importantly ...

Dec 15 10:25:25 <mclasen> pat: fixed recently
Dec 15 10:25:50 <pat> mclasen: okay, that explains why people who upgraded to
2.8.8 had it fixed.
Dec 15 10:26:08 <pat> mclasen: are you aware of a simple workaround? Explicitly childing a label or somethign?
Dec 15 10:26:34 <mclasen> pat: how about just adding some text ?
Dec 15 10:26:53 <pat> mclasen: that's what I meant.

So, that's exactly what I'll try this evening. If I'm not too drunk.

[suwalski]

So, the reason it was working for me on Sarge is that I didn't have the security updates. The label bug did not exist in my version 2.6.2-4, while it does after upgrading to 2.6.4-3.1 from the security updates.

I created a simple workaround just as mclasen suggested. It works.

I also added compile-time checks for the other things that don't work on 2.6.x, so it should compile cleanly now.

I hope that was my last change before 1.4.0.

[steffens]

Great! Many, many thanks!
I will try a compile on a fresh CVS update as soon as possible. Now if only there were bookmarks and localization implemented...

steffens

[suwalski]

Now if only there were bookmarks and localization implemented...

Those are my #1 items on the list for 1.5.0, after an upgrade and cleaning of the autoconf script. Its order right now makes no sense.

After that goes in, I'm considering making a pseudo-release and posting it on Ubuntu's Rosetta:

https://launchpad.net/rosetta

It will probably then get translated to a dozen languages within a few weeks.