Celestia 1.7.0 Development Thread

cartrite · Post #1101by **cartrite** » 26.12.2021, 20:50

Ok, I think your saying that it is only created once. With win32 it is created in winmain and destroyed in celestiacore and with qt it is created in celestiacore and destroyed in celestiacore. Once it is created it can't be created again? Anyway, another question, When will there be a code freeze for a release? I'm seeing a lot of activity on github these days and I'm wondering when would be a good time to provide an installer. Or should I provide one weekly, bi-weekly, monthly?

Post #1102by **onetwothree** » 27.12.2021, 08:30

If the logger is already created then it won't be created again, but an existing one will be used.
Regarding the 2nd question - we don't have any plans for code freeze yet. For me monthly snapshots are reasonable frequency.

cartrite · Post #1103by **cartrite** » 27.12.2021, 10:19

I was just concerned about a memory leak. Thank You for all. I was looking at those 2 lines of code in celestiacore but couldn't see the solution.

I'm gonna get started on an installer now. Today or tomorrow. The last installer I did I added textures but I see that there were upgrades to textures in hires so this installer will only contain what was downloaded from github. Pure. Qt and Win32.

Added after 23 minutes 9 seconds:
I'm still confused about translations though. With Linux, the Celestia folder gets installed in /usr/local/share/celestia and the translation folder gets installed in /usr/local/share/locale. But there is also a locale folder in /usr/local/share/celestia. So there are 2 of them. With Windows all the translation folders get installed in the root directory., not the installation directory. And they are all separate folders. So I have been cutting them into a locale folder the way Linux does. Should the Windows installer provide 2 folders? One for celestia and one for locale or should I paste all the translation folders into celestia/locale?

Added after 4 hours 2 minutes:
I'm going to download and build a snapshot today unless someone has an important update they are ready to commit. At 12 pm edt.

Post #1104by **onetwothree** » 27.12.2021, 17:23

Yes, on windows all translations should be in the same subfolder of Celestia's root folder. If something is installed into a root folder than it's a bug in our cmake configuration.

cartrite · Post #1105by **cartrite** » 28.12.2021, 13:54

I made 3 attempts to upload the installer but after it finishes uploading I get an error Error parsing server response. The file is quite large 282 mb. Any ideas?

Added after 2 minutes 17 seconds:
The texture folder alone is 208 mb. Maybe I should create an installer without it.

Added after 1 hour 27 minutes:
I was able to upload the installer without the textures folder. By default it will run celestia-win but celestia-qt is in Programs Files\Celestia. A shortcut to the desktop will need to be added manually. If installed into an existing folder the textures should still be available. Or if installed into a new location, copy the texture folder into it .

Added after 3 hours:
I noticed that the content folder is being removed as a sub-module. I have a suggestion. Have a bare minimum of content files within the master to get the installation running. Then provide a means within the installed program to add the content. As with flight simulator. With that program, one installs the base program and the content is separate. It is downloaded and installed for use separately.

I removed this installer from this post. The latest one is now here.
viewtopic.php?p=156123#p156123

john71 · Post #1106by **john71** » 28.12.2021, 20:07

It works fine, but there are some strange artifacts:

2021-12-28 20_57_11-Celestia art.png

cartrite · Post #1107by **cartrite** » 28.12.2021, 20:09

what do you mean?

john71 · Post #1108by **john71** » 28.12.2021, 20:11

Those strange squares on the image!

They are like miniature mobile phones lol.

cartrite · Post #1109by **cartrite** » 28.12.2021, 20:12

Those rectangles in the numbers?

john71 · Post #1110by **john71** » 28.12.2021, 20:13

Yeah.

cartrite · Post #1111by **cartrite** » 28.12.2021, 20:16

I didn't notice. I'll take a look. I don't see that when I run it. What number are those rectangles replacing?

Added after 3 minutes 37 seconds:
Maybe you should provide a cel url that demonstrates the problem.

Added after 1 minute 8 seconds:
Might have something to do with translations.

john71 · Post #1112by **john71** » 28.12.2021, 20:23

The numbers are 31*89*1 and 6*37*8, so 89 and 37. Very strange.

cartrite · Post #1113by **cartrite** » 28.12.2021, 20:27

I've been closer and farther from earth but didn't see the squares. If you can copy the url from where this happens I could check.

john71 · Post #1114by **john71** » 28.12.2021, 20:30

It happens everywhere, all the time. Even on stars. Must be OS (win10) and language related.

Or because of the partial installation file?

cartrite · Post #1115by **cartrite** » 28.12.2021, 20:33

what language are you using?

Added after 2 minutes 49 seconds:
That I didn't check. It is a pain to change languages. With linux, I checked a while back and it took quite a while before my machine went back to English. With windows I never got translations to work.

john71 · Post #1116by **john71** » 28.12.2021, 20:37

Central-European, latin alphabet.

cartrite · Post #1117by **cartrite** » 28.12.2021, 20:48

This an issue with the translations which I have nothing to do with. I just built what they wrote. But it does show that translations are trying to work. We will have to wait until they respond.

john71 · Post #1118by **john71** » 28.12.2021, 20:54

OK, thanks.

cartrite · Post #1119by **cartrite** » 28.12.2021, 21:07

Question though. Which interface where you using win or qt? Try using the other. The qt interface is in the folder where ever you installed this. Using windows, send it to the desktop to the desktop to create a shortcut. See if those translation work on qt.

john71 · Post #1120by **john71** » 28.12.2021, 21:11

Qt is even stranger. Same rectangles but there are partially translated texts too.