Celestia 1.7.0 Development Thread

The place to discuss creating, porting and modifying Celestia's source code.
Avatar
gironde M
Posts: 851
Joined: 16.12.2016
Age: 72
With us: 7 years 11 months
Location: Montigny-Les-Metz, France

Post #1081by gironde » 23.09.2021, 05:47

I have a suggestion for developers that has nothing to do with your current concerns.
For some time now I've been creating a lot of ssc files for different objects. Flight data is found on a few sites like JPL, MPC, wikipedia and others. All of these sites use the physical parameter, Diameter, and never Radius. Only Celestia uses Radius. It is not difficult to switch between them but when you do large sets of ssc it becomes painful. Why not add Diameter to Celestia but keep Radius for compatibility with files already made? Radius would still be the base setting but Celestia would change Diameter to Radius internally.
:think:

Avatar
Art Blos M
Moderator
Posts: 1150
Joined: 31.08.2017
Age: 32
With us: 7 years 2 months
Location: Volgodonsk, Rostov Oblast, Russia

Post #1082by Art Blos » 03.12.2021, 19:33

cartrite < Isn't it time to build a more recent installer? :smile:
Founder and head of the project "Celestia Origin"

Avatar
gironde M
Posts: 851
Joined: 16.12.2016
Age: 72
With us: 7 years 11 months
Location: Montigny-Les-Metz, France

Post #1083by gironde » 10.12.2021, 16:59

lua-applications does not load with Celestia 1.7.0. Is it no longer compatible? LuaHook added to celestia.cfg is ineffective!

:eek:

Topic author
onetwothree
Site Admin
Posts: 706
Joined: 22.09.2018
With us: 6 years 2 months

Post #1084by onetwothree » 10.12.2021, 18:35

gironde wrote:lua-applications does not load with Celestia 1.7.0. Is it no longer compatible? LuaHook added to celestia.cfg is ineffective!

It should work. Do you have any errors logged?

Avatar
gironde M
Posts: 851
Joined: 16.12.2016
Age: 72
With us: 7 years 11 months
Location: Montigny-Les-Metz, France

Post #1085by gironde » 11.12.2021, 10:48

in extras-standard/Galileo:
error openning "\extras-standard\galileo\data\galileo-cruise.xyzvbin"
and "\extras-standard\galileo\data\galileo-orbit.xyzvbin"

Why xyzvbin?
Sans titre 3.jpg

Sans titre 5.jpg


no traduction : the local / res_ * dll files are missing (those of 1.6.2.2 incompatible)

no lua-application file is loaded they are all in error (except gap1box.lua which is an empty box)

The main error is probably due to missing files in 'locale' and this error is reflected in LUT5 which also supports different languages.

I use both Celestia 1.6.1, 1.6.2.2 and now 1.7.0
With 1.6.1 and 1.6.2.2, my "extras" and "lua-applications" files are common (on a D: / disk) which limits the size of the files used
It doesn't seem to work anymore with this build of 1.7.0. So what has changed: lua51.dll, fonts, and locale

I made a discovery in LUT5:
LUT5 can use the DejaVuSans-Bold.ttf and DejaVuSans.ttf fonts

to use them, you must first copy these 2 fonts in the "fonts" folder of Celestia 1.6.1 and 1.6.2.2
THE "fonts" FOLDER IN LUT5 IS IN FACT NOT USED
Then you have to modify the textlayout.lua file (and maybe the one used in the old lua-edu-tools modules)

in textlayout.lua

Code: Select all

-- titlefont = celestia: loadfont ("fonts / sansbold20.txf") - load a font txf
titlefont = celestia: loadfont ("fonts / DejaVuSans-Bold.ttf,15")

-- normalfont = celestia: loadfont ("fonts / sans12.txf") - load a font txf
normalfont = celestia: loadfont ("fonts / DejaVuSans.ttf,9")

-- labelfont = celestia: loadfont ("fonts / sans14.txf") - load a font txf ("fonts / sans14_ru.txf")
labelfont = celestia: loadfont ("fonts / DejaVuSans.ttf,9")

-- smallfont = celestia: loadfont ("fonts / sans10.txf") - load a font txf
smallfont = celestia: loadfont ("fonts / DejaVuSans.ttf,8")



:hi:

Added after 7 minutes 40 seconds:
It seemed to me that we could with 1.7.0 recover in a file the log generated during the loading? But how do we do it?

Topic author
onetwothree
Site Admin
Posts: 706
Joined: 22.09.2018
With us: 6 years 2 months

Post #1086by onetwothree » 12.12.2021, 08:30

gironde wrote:in extras-standard/Galileo:
error openning "\extras-standard\galileo\data\galileo-cruise.xyzvbin"
and "\extras-standard\galileo\data\galileo-orbit.xyzvbin"

Why xyzvbin?

You can ignore this message. It's just because binary version of xyzv file is not found. Original text version will be used instead.

gironde wrote:no lua-application file is loaded they are all in error (except gap1box.lua which is an empty box)

The main error is probably due to missing files in 'locale' and this error is reflected in LUT5 which also supports different languages.

No. I run LUT5 without any issues despite the missing files.

gironde wrote:It seemed to me that we could with 1.7.0 recover in a file the log generated during the loading? But how do we do it?

With a version with Qt interface you can pass option "-l file.log" of "--log file.log" and file.log will contain complete output.

Avatar
gironde M
Posts: 851
Joined: 16.12.2016
Age: 72
With us: 7 years 11 months
Location: Montigny-Les-Metz, France

Post #1087by gironde » 12.12.2021, 08:59

I had installed this version posted in the forum but certainly that it is not successful :
viewtopic.php?p=154727#p154727

As there is no official version yet, with or without qt, I believe that it is urgent to wait and not to rush. Let's take advantage of 1.6.1 and 1.6.2.2.
In the meantime, thank you for taking the time to answer me. :smile: :hi:

Avatar
cartrite
Posts: 1978
Joined: 15.09.2005
With us: 19 years 2 months
Location: Pocono Mountains, Pennsylvania, USA Greate Grandfother from Irshava, Zakarpattia Oblast Ukraine

Post #1088by cartrite » 16.12.2021, 15:23

Art Blos wrote:cartrite < Isn't it time to build a more recent installer? :smile:
I'll look into it tonight.
VivoBook_ASUSLaptop X712JA_S712JA Intel(R) UHD Graphics 8gb ram. Intel(R) Core(TM) i5-1035G1 CPU @ 1.00GHz, 1190 Mhz, 4 Core(s), 8 Logical Processor(s) 8 GB ram. Running on Windows 11 and OpenSuse 15.4

Avatar
cartrite
Posts: 1978
Joined: 15.09.2005
With us: 19 years 2 months
Location: Pocono Mountains, Pennsylvania, USA Greate Grandfother from Irshava, Zakarpattia Oblast Ukraine

Post #1089by cartrite » 22.12.2021, 02:10

OK everything built well, just have to put all the files into place which could take a few more days. I had a major update recently. Now on win 11.
VivoBook_ASUSLaptop X712JA_S712JA Intel(R) UHD Graphics 8gb ram. Intel(R) Core(TM) i5-1035G1 CPU @ 1.00GHz, 1190 Mhz, 4 Core(s), 8 Logical Processor(s) 8 GB ram. Running on Windows 11 and OpenSuse 15.4

Avatar
cartrite
Posts: 1978
Joined: 15.09.2005
With us: 19 years 2 months
Location: Pocono Mountains, Pennsylvania, USA Greate Grandfother from Irshava, Zakarpattia Oblast Ukraine

Post #1090by cartrite » 23.12.2021, 00:44

I'm having a bit of a problem with the latest build. celestia-qt starts but celestia-win does not. At first it complained about missing dll's but after I installed them all, it does nothing. Does not start. I tried running from powershell, terminal and nothing happens. So..........

Added after 17 minutes 41 seconds:
I don't even get an error message. I click on it, the wheel spins, then it goes away. Nothing happens.

Added after 9 hours 54 minutes:
I built version b94d084. Something went wrong 3 days ago when the logger was implemented. This version starts.
VivoBook_ASUSLaptop X712JA_S712JA Intel(R) UHD Graphics 8gb ram. Intel(R) Core(TM) i5-1035G1 CPU @ 1.00GHz, 1190 Mhz, 4 Core(s), 8 Logical Processor(s) 8 GB ram. Running on Windows 11 and OpenSuse 15.4

Topic author
onetwothree
Site Admin
Posts: 706
Joined: 22.09.2018
With us: 6 years 2 months

Post #1091by onetwothree » 24.12.2021, 09:33

i will check

Avatar
cartrite
Posts: 1978
Joined: 15.09.2005
With us: 19 years 2 months
Location: Pocono Mountains, Pennsylvania, USA Greate Grandfother from Irshava, Zakarpattia Oblast Ukraine

Post #1092by cartrite » 24.12.2021, 11:37

Maybe a new and missing dependency?
VivoBook_ASUSLaptop X712JA_S712JA Intel(R) UHD Graphics 8gb ram. Intel(R) Core(TM) i5-1035G1 CPU @ 1.00GHz, 1190 Mhz, 4 Core(s), 8 Logical Processor(s) 8 GB ram. Running on Windows 11 and OpenSuse 15.4

Topic author
onetwothree
Site Admin
Posts: 706
Joined: 22.09.2018
With us: 6 years 2 months

Post #1093by onetwothree » 24.12.2021, 11:50

no, nothing was added. some code issues probably as we don't check win32 ui

Avatar
cartrite
Posts: 1978
Joined: 15.09.2005
With us: 19 years 2 months
Location: Pocono Mountains, Pennsylvania, USA Greate Grandfother from Irshava, Zakarpattia Oblast Ukraine

Post #1094by cartrite » 25.12.2021, 10:39

With windows, I don't have a clue as to what is going on. But that is how windows works. When I run celestia-qt in a terminal, there is no output on the terminal. It just returns to a new prompt. A different command can then be entered. But celestia-qt starts. Anyhow, I ran celestia-win on Linux with wine and I do get a message that the program has to close. I saved the backtrace file. Hope this can help.
backtrace.txt
(6.54 KiB) Downloaded 174 times
It seems that the program is trying to access memory outside of it's allotted space.
VivoBook_ASUSLaptop X712JA_S712JA Intel(R) UHD Graphics 8gb ram. Intel(R) Core(TM) i5-1035G1 CPU @ 1.00GHz, 1190 Mhz, 4 Core(s), 8 Logical Processor(s) 8 GB ram. Running on Windows 11 and OpenSuse 15.4

Avatar
cartrite
Posts: 1978
Joined: 15.09.2005
With us: 19 years 2 months
Location: Pocono Mountains, Pennsylvania, USA Greate Grandfother from Irshava, Zakarpattia Oblast Ukraine

Post #1095by cartrite » 26.12.2021, 03:16

You can probally rule out fmt as a possible cause. A while back I had a problem with fmt ver 8. So I downgraded to version 7. Which fixed the problem with fprint I was having at the time. I reinstalled version 8 and the build worked but the app still wouldn't start. I also tried commenting out all the changes to winmain.cpp. Still didn't work. :wink: I can build commit b94d084 and create an installer for that but I'm thinking that unless this is fixed I won't be able to build that ui again. Maybe it's time to let the win32 ui RIP. On linux, the gtk ui works.
VivoBook_ASUSLaptop X712JA_S712JA Intel(R) UHD Graphics 8gb ram. Intel(R) Core(TM) i5-1035G1 CPU @ 1.00GHz, 1190 Mhz, 4 Core(s), 8 Logical Processor(s) 8 GB ram. Running on Windows 11 and OpenSuse 15.4

Topic author
onetwothree
Site Admin
Posts: 706
Joined: 22.09.2018
With us: 6 years 2 months

Post #1096by onetwothree » 26.12.2021, 09:05

Qt build works under wine, so I think the problem is not with fmt 8.

Avatar
cartrite
Posts: 1978
Joined: 15.09.2005
With us: 19 years 2 months
Location: Pocono Mountains, Pennsylvania, USA Greate Grandfother from Irshava, Zakarpattia Oblast Ukraine

Post #1097by cartrite » 26.12.2021, 12:13

Until yesterday I was using fmt 7 with vcpkg. But I notice there is a fmt in thirdparty. Anyhow I was just trying fmt8 to see if celestia-win would start. It didn't. Qt runs on windows 11, wine and linux. Gtk runs on linux. Only the win32 ui is affected by this. The thing that sucks is windows doesn't show what's going on or why it fails to start. I'm thinking it's a segmentation fault.
VivoBook_ASUSLaptop X712JA_S712JA Intel(R) UHD Graphics 8gb ram. Intel(R) Core(TM) i5-1035G1 CPU @ 1.00GHz, 1190 Mhz, 4 Core(s), 8 Logical Processor(s) 8 GB ram. Running on Windows 11 and OpenSuse 15.4

Topic author
onetwothree
Site Admin
Posts: 706
Joined: 22.09.2018
With us: 6 years 2 months

Post #1098by onetwothree » 26.12.2021, 17:57


Avatar
cartrite
Posts: 1978
Joined: 15.09.2005
With us: 19 years 2 months
Location: Pocono Mountains, Pennsylvania, USA Greate Grandfother from Irshava, Zakarpattia Oblast Ukraine

Post #1099by cartrite » 26.12.2021, 19:37

Yes it did. I'll get an installer built soon.

Added after 7 minutes:
Question though. I noticed that the only place I could find where a logger was created was in celestiacore.cpp. Then it was destroyed. But in winmain there is no destroy. why?
VivoBook_ASUSLaptop X712JA_S712JA Intel(R) UHD Graphics 8gb ram. Intel(R) Core(TM) i5-1035G1 CPU @ 1.00GHz, 1190 Mhz, 4 Core(s), 8 Logical Processor(s) 8 GB ram. Running on Windows 11 and OpenSuse 15.4

Topic author
onetwothree
Site Admin
Posts: 706
Joined: 22.09.2018
With us: 6 years 2 months

Post #1100by onetwothree » 26.12.2021, 20:18

Because it still will be called in destructor of CelestiaCore. If will call it in the very end of WinMain, then it will be destroyed twice and as DestroyLogger doesn't set it to nullptr then it will be double free error which will abort the application.


Return to “Development”