Celestia 1.7.0 Development Thread

[Janus]

A quick note to those making commits.

The windows SDK for 8.1/10 reserves the lower case word small as a char of some sort.

rpcndr.h

Code: Select all

#define small char
typedef unsigned char byte;
typedef byte cs_byte;
typedef unsigned char boolean;


Which creates a problem in glmarker.cpp:InitVO
Two(2) vector<glfloats> are declared, small and large, which creates a conflict.
To get it to compile I changed them to smaller & larger, which preserves the logic and transparency.
These give errors that are a pain to chase down since the rest of the file fails to parse until that is fixed.
Very discouraging for those using VS in windows.
The same problem probably applies in QT as well, but I do not have it installed to test.
There are other issues, but this one is a show stopper.
Someone should fix it.


Janus.

[onetwothree]

Stupid microsoft!

Thanks for report, Janus.

Added after 7 minutes 11 seconds:
On the other hand, are you sure that you don't include any unneeded .h files? I use VC++ 2015 just as you do and I don't have this error. What happens if you define the following:

Code: Select all

    -D_CRT_SECURE_NO_WARNINGS
    -D_SCL_SECURE_NO_WARNINGS
    -DNOMINMAX
    -DWIN32_LEAN_AND_MEAN
    -DWINVER=0x0601
    -D_WIN32_WINNT=0x0601


[Janus]

@onetwothree

I am not sure where to put those, so here is what I used.

https://celestia.simulatorlabbs.com/Downloads/

Grab Celestia-5719-Complete.7z from within, and try it yourself.
Extract where ever, it will create a celestia-5719 directory.
Look in the vs directory under that.
Two sets of solutions, one for txf, the other ttf.

It also includes Lua534 & Lua515, currently setup to use Lua515 since I dislike # and prefer getn.
Once I figure out how to include both the txf & ttf in one, I will recombine them.

I would try to test, but I am fighting the M$ WIL library explorer++ devs have decided to use.
I am beginning to doubt I will be able to make it work with VS2015, which stinks.


Janus.

[onetwothree]

Code: Select all

<PreprocessorDefinitions> CELX;LUA_VER=0x050300;USE_SPICE;_CRT_SECURE_NO_DEPRECATE;NOMINMAX;HAVE_EXPERIMENTAL_FILESYSTEM;GLEW_STATIC;%(PreprocessorDefinitions)</PreprocessorDefinitions>

Try to add WIN32_LEAN_AND_MEAN

[Janus]

@onetwothree

No change.

Can you send me the sln/vcxproj made by cmake.
I can do a compare from there.

Did you try mine?


Janus.

[onetwothree]

will do this sunday.

[onetwothree]

quite interesting that even with your archive i'm unable to reproduce your error, maybe we have different windows sdk versions.

[Janus]

@onetwothree

Did you change smaller to small, & larger to large in glmarker.pp:initvo function?
I had it working in the archive I made.


Janus.

[onetwothree]

Reverted your changes - failed to compile. Added WIN32_LEAN_AND_MEAN - successfully compiled, as expected.

[jujuapapa]

...
https://celestia.simulatorlabbs.com/Downloads/
...
Janus.

Downloaded and installed this Morning.

I Don't know if this anomaly has been said but the datas of the frame "stellar browser" Always begins by the Sun.
Even when you are near another star.

On 1.6.1, the list begins by the closest star.

[Janus]

@onetwothree

Weird.
Though I am happy you didn't have any trouble with it.
A lot of people I have worked with have had problems dealing with portable or self contained projects.

I will continue looking into this however.
That means one or more of my customizations has had an unanticipated side effect.
Of course, I also use the 8.1 SDK, and only recently, and reluctantly, installed 10.1.18632 for testing.

I have been fighting the WIL library, trying to make it work with VS2015.
Explorer++ has gone to using it, and since I cannot use VS2019, I may not be able to use newer versions of explorer++.
I may have broken something subtle.

Perhaps it is time for a clean slate in a VM.


Janus.

[selden]

Problem: Celestia v1.7 draws Earth red when an orbiting sphere is defined.
This problem is not seen with Celestia v1.6.1 or v1.6.2 beta2

I'm guessing there might be a problem in one of the shaders.

This Addon demonstrates this bug.

Tha enclosed "redden.html" provides a CEL:// URL which takes you to a viewpoint which shows a red Earth.

The enclosed "redden.ssc" defines an object orbiting the Earth and which generates the problem.

Celestia v1.6.1 was installed using the SourceForge version at https://sourceforge.net/projects/celestia/

Celestia v1.6.2b2 was installed using the installer at https://bintray.com/celestia/celestia-builds/down ... h=celestia-1.6.2-beta2pre1.exe

Most Celestia v1.7 resources were installed using download/file.php?id=6847&filename=CelestiaResources.zip
as provided by Markerz
Current shaders were downloaded from Github today (10jan20).

Celestia v1.7 binaries were installed using Janus' version at
download/file.php?id=6975&filename=Celestia-TestObject.7z

[onetwothree]

I'm unable to reproduce the error. Could you post shaders.log? It should be located near the executable file.

Added after 1 minute 3 seconds:
Also, could you disable eclipse shadows and recheck?

Added after 1 minute 55 seconds:
Do you have additional light sources besides the Sun?

[selden]

The problem goes away when either "Cloud Shadows" or "Clouds" is deselected. Disabling "Eclipse shadows" makes no difference. The problem actually seems to happen only when the object's shadow is *not* being drawn on the Earth.

I have no additional light sources: the test was done with no Addons or catalogs other than what are included with Celestia v1.7

I've attached a revised copy of the Addon. The zip includes a zip of shaders.log for when the problem happens.

screengrab showing Render View Options and red Earth.

redden.zip

addon showing red Earth problem

(355.24 KiB) Downloaded 169 times

[onetwothree]

Hmm, only native frontend affected

Added after 9 minutes 51 seconds:
actually qt is affected as well but on win, not affected on gnu/linux. weird.

@Markerz could you check on macOS?

[Markerz]

macOS is affected too

[onetwothree]

Hi!

Selden, SevenSpheres, please test attached exe, it should fix all currently reported issues with red planets:
https://github.com/CelestiaProject/Celestia/issues/565 (reported by SevenSpheres) - I don't see any problems
https://github.com/CelestiaProject/Celestia/issues/583 (reported here by Selden) - tested both by me & Markerz.

[SevenSpheres]

With that .exe galaxies appear as bright red squares, and the Sun is too dark, as if Celestia was in "scaled disks" mode. Same with any random star. The red/dark planet bug is fixed though.

EDIT: With the shaders linked by onetwothree galaxies render correctly.

[onetwothree]

Do you have https://github.com/CelestiaProject/Celestia/blob/master/shaders/galaxy_frag.glsl and https://github.com/CelestiaProject/Celestia/blob/master/shaders/galaxy_vert.glsl?

[selden]

The red eclipse problems seem fixed for me, too.