Celestia 1.7.0 Development Thread

[onetwothree]

Commit 5436, Porrima A

Commit 5441, Porrima A

Could you translate them to git commits?

[Janus]

I am using the git commit #s

goto Github, look on the left above the filenames.
You will see the words commits and a number.
The number you see is the latest commit, click on it.
You will see a list of commits, the largest number on the top, with numbers descending.
The numbers I use are those commit numbers.
If you want to see the project at an earlier commit state, look on the right.
There is a clipboard, a number, and some brackets.
Middle click on the brackets to open the project at that commit in a new window.
The number beside the word commits is the version you will get from the clone or download button on the right.


Janus.

[onetwothree]

so, 5436 is 45836d993a8d2ce947f17629c73dd579ea00a806 and 5441 is b2d88df04aaf589cdc609e24e6a4f3c581112431

There is not changes touching render code.

[Janus]

I do not use the large numbers in keeping track of things.
The sequential method is of far more use to me.
I need order of operations or occurrence for what I do.

And no, there was no rendering code changes.
I am not sure what was causing the problem.
I started over, recreating what I did from scratch, and it did recur.
Thus I decided to let it go.

The working code for RaDecDist is over in a forking thread.
Use it if you like, or ignore it, whatever.


Janus.

[Lafuente_Astronomy]

Hello guys, and especially to onetwothree. Do you mind if I rename the title of this thread to "Time to Restart Development: The Official Celestia 1.7.0 Development Thread"? I feel that it makes the post slightly more informative in nature

If you don't want what I suggested but want to suggest a better title, I can accept that

Thanks in advance

[onetwothree]

Maybe just "Celestia 1.7.0 Development Thread"?

[Lafuente_Astronomy]

Maybe just "Celestia 1.7.0 Development Thread"?

Granted

Added after 9 hours 45 minutes:
Alright, there are some new problems.

A member of the Discord Server pointed out that Moons, Dwarf Planets and Asteroids do not appear at all when one goes to them in Celestia. I did a check and this is what I found out:

Going to Ceres, I was met with this:

And finally going to Pluto, I saw this:

And just to prove to you that it's a problem, the model files for Moons, Asteroids and Dwarf Planets is actually turned on from the start:

I know there are more important things to deal with in Celestia 1.7.0, especially the coding but if you have the time, can you try to make the visible once again? I trust in your judgments and if their disappearance is related to the code, then I will accept it.

More power to you and Thank you for developing Celestia 1.7.0

Added after 24 minutes 57 seconds:
Update:

Another member pointed out that they become visible if you uncheck the boxes. In short, it's there but perhaps a reversal of the options should be done, in which check=visible and uncheck=invislbe. It is confusing when the values are opposite to what is checked

[Janus]

A quick note to whom ever wrote the greek substitution code.
You need to add a separator, like only activating after a space.
The replace substring behavior it currently has responds to matches contained within other names.
The proper behavior would be to replace only exact stand alone caseless matches.

Look at HIP 67927 {Muphrid}, which was pointed out to me in my forking thread, for what is happening.
I am sure there are many others.


Janus.

[Lafuente_Astronomy]

A quick note to whom ever wrote the greek substitution code.
You need to add a separator, like only activating after a space.
The replace substring behavior it currently has responds to matches contained within other names.
The proper behavior would be to replace only exact stand alone caseless matches.

Look at HIP 67927 {Muphrid}, which was pointed out to me in my forking thread, for what is happening.
I am sure there are many others.


Janus.

Just to make sure, I'll try searching Muphrid without using your fork. Just to make sure

[cartrite]

I just built the win version from commit 9a851f0e (5446) with win 7 running on VMWare. I can confirm the that the selection process behavior above. But it is also in the qt version running on Linux Tumbleweed. Typing in "muphrid" shows nothing and hitting enter selects nothing. Typing in "Muphrid" also shows nothing but selects Muphrid and shows "uphrid" in the verbose. Version commit 45836d99, typing just "mup" had the selection Muphrid available and when selected displayed the correct verbose. "Muphrid". This is the last commit I built that shows "correct?" behavior. Commit b2d88df0 is the first version I Built that shows the incorrect behavior.

[onetwothree]

pirogronian is working on fix for greek letter replacement, i'l try his pr this evening and if everything is ok (existing bugs are fixed and no new introduced) we will merge it and provide new test builds

Added after 1 minute 16 seconds:

Another member pointed out that they become visible if you uncheck the boxes. In short, it's there but perhaps a reversal of the options should be done, in which check=visible and uncheck=invislbe. It is confusing when the values are opposite to what is checked

Is this for Windows native version only or for Qt-based one too?

[cartrite]

My added post got lost
Anyhow I looked into the asteroid and dwarf planet issue. It past versions, asteroid.* was loaded when selecting and going to ceres. Now a blank sphere is shown but no texture is loaded. The log says it trys to load ceres.*. In past versions, asteroid.* was loaded. This is in the win version running on VMWare and the qt version on linux. The only version I got that reproduces invisible dwarfs or asteroids is Janus's hubble version 5426. Of course, I have no texture ceres.jpg. So............

Added after 7 minutes 2 seconds:
On version 5426, unchecking does show ceres with asteroid.jpg texture. So 2 different issues?

[Lafuente_Astronomy]

Is this for Windows native version only or for Qt-based one too?

I'll see if it's present in the QT as well. I don't really use the QT version that much

[cartrite]

Tried a simple fix. Copied and renamed asteroid.jpg to ceres.jpg. Works but ceres is now circular. In the past it was shaped like an oval. So this is an *.ssc issue.

[Lafuente_Astronomy]

The objects apparently work in the QT version. It's more of a Windows problem I guess.

Added after 1 minute 35 seconds:

Tried a simple fix. Copied and renamed asteroid.jpg to ceres.jpg. Works but ceres is now circular. In the past it was shaped like an oval. So this is an *.ssc issue.

Wait, isn't Ceres the most spherical of the Asteroids? I think the Oval Ceres model is an inaccurate one.

[cartrite]

From what I see, you may be correct. The reason ceres is circular is a line was left out of dwarf-planets.ssc for Ceres.

Code: Select all

Oblateness 0.068    # Thomas et al, Nature, 8 Sep 2005

I'm unqualified to judge if that line should be used. I'm only stating something has changed.

I noticed that for ceres at least, it's entry was taken out of data/asteroids.ssc and put in extras-standard/dwarf-planets.ssc. What I'm seeing, only a texture for ceres is needed.

Added after 10 minutes 27 seconds:

The objects apparently work in the QT version. It's more of a Windows problem I guess.

I think this issue is with Janus's builds. I see the same behavior with latest git commit on both the linux qt version and win versions. On these I see Pluto fine. I see a sphere for Ceres but no texture.

[Lafuente_Astronomy]

I think this issue is with Janus's builds. I see the same behavior with latest git commit on both the linux qt version and win versions. On these I see Pluto fine. I see a sphere for Ceres but no texture.

Yup. He had a comment concerning these problems in his own thread

[Janus]

A note for whomever moved Ceres and companions from data to extras.
Ceres lacks a texture of its own.
In its former incarnation it used asteroid.jpg.
Now it uses ceres.*, which does not exist, which is why it is so pale and white, not a lack sunlight in the belt.

Someone should retrieve a texture for it, and verify the rest have textures as well.
I would recommend a comment in the debug file if a texture is missing.


Janus.

[cartrite]

One available here

[john71]

This is the same texture error and "invisible moon" problem I experienced a few month earlier with post-Alexell Celestia builds.