Dimensions of default marker need to be changed

Report bugs, bug fixes and workarounds here.
Topic author
bdm
Posts: 461
Joined: 22.07.2005
With us: 19 years 4 months
Location: Australia

Dimensions of default marker need to be changed

Post #1by bdm » 23.01.2009, 02:42

In Celestia 1.4.1, stars of a certain brightness (when rendered as scaled disks) appeared to be square when centred, taking up 2 x 2 pixels. The default marker was consistent with this, being a diamond of 10 x 10 pixels. Both dimensions were even numbers.

In Celestia 1.5.0, the shape of the stars changed so the centre of the star was a single pixel; stars that were 2 x 2 pixels now appear as a cross of five pixels. However, the default marker is still a diamond of 10 x 10 pixels. When the marker marks a centred star, the marker appears off-centre.

To be consistent, the default marker needs to be changed to a 9 x 9 or 11 x 11 diamond.

(This may have been corrected in a more recent version but 1.5.0 is the latest version that I have installed at the moment.)

Avatar
selden
Developer
Posts: 10192
Joined: 04.09.2002
With us: 22 years 2 months
Location: NY, USA

Re: Dimensions of default marker need to be changed

Post #2by selden » 23.01.2009, 17:27

What is the "certain brightness"?
Can you provide a URL which demonstrates this problem?

I'm not seeing it on my Windows system running any version of Celestia but I'm not sure I'm looking at things right.

[edit]

1. v1.6 uses an entirely different type of indicator to show which object is selected. I'm not sure if that's what you mean by "default". The new marker is animated.

2. When one "marks" a dim star in v1.6 the resulting green diamond seems to be offset somewhat, but this is the case for both scaled discs and fuzzy points. "Star style: points" does draw stars centered in the diamond. The diamond doesn't move, so this suggests to me that the problem is in the position where stars are drawn in the other two styles, not in the position of the marker.
Selden

Topic author
bdm
Posts: 461
Joined: 22.07.2005
With us: 19 years 4 months
Location: Australia

Re: Dimensions of default marker need to be changed

Post #3by bdm » 24.01.2009, 02:37

selden wrote:What is the "certain brightness"?
Can you provide a URL which demonstrates this problem?
Sorry for not providing enough info in my original post, as it was a hot summer's day and was felling a bit grumpy from the heat.
Primus Hyadum
Star style = scaled disks, limiting magnitude is 6.64. However, exact brightness of the star is not important because they all appear off-centre.

selden wrote:1. v1.6 uses an entirely different type of indicator to show which object is selected. I'm not sure if that's what you mean by "default". The new marker is animated.
This suggests to me that the issue may be an old issue.

selden wrote:2. When one "marks" a dim star in v1.6 the resulting green diamond seems to be offset somewhat, but this is the case for both scaled discs and fuzzy points. "Star style: points" does draw stars centered in the diamond. The diamond doesn't move, so this suggests to me that the problem is in the position where stars are drawn in the other two styles, not in the position of the marker.
The following is what I get with the above URL and settings. I have magnified the image by 16 times for convenience.
scaled-disk.png

It is clear from the above image that the marked star is off-centre within the marker. The star would be centred within the marker if the marker was enlarged in size by 1 pixel in both directions and the marker retained its position relative to the top left of the star:
scaled-disk-new.png

Topic author
bdm
Posts: 461
Joined: 22.07.2005
With us: 19 years 4 months
Location: Australia

Re: Dimensions of default marker need to be changed

Post #4by bdm » 24.01.2009, 02:42

Here is the same star with points selected:
points.png


Here is the same star with fuzzy points:
fuzzy-points.png


selden wrote:2. When one "marks" a dim star in v1.6 the resulting green diamond seems to be offset somewhat, but this is the case for both scaled discs and fuzzy points. "Star style: points" does draw stars centered in the diamond. The diamond doesn't move, so this suggests to me that the problem is in the position where stars are drawn in the other two styles, not in the position of the marker.
This looks similar to what is happening in the older version. Note how the middle of the star is placed 1 pixel down and right when fuzzy points and scaled disks is selected, compared to its position when points is selected.

Avatar
selden
Developer
Posts: 10192
Joined: 04.09.2002
With us: 22 years 2 months
Location: NY, USA

Re: Dimensions of default marker need to be changed

Post #5by selden » 24.01.2009, 13:37

As best I can tell, exactly the same problem is present in v1.6
Selden

ElChristou
Developer
Posts: 3776
Joined: 04.02.2005
With us: 19 years 9 months

Re: Dimensions of default marker need to be changed

Post #6by ElChristou » 24.01.2009, 17:47

This is a really tiny detail, but yes in the absolute, this need to be fix...
Image

Topic author
bdm
Posts: 461
Joined: 22.07.2005
With us: 19 years 4 months
Location: Australia

Re: Dimensions of default marker need to be changed

Post #7by bdm » 25.01.2009, 00:39

There are actually two issues here. There's the marker issue I raised, and also the issue that Seldon mentioned where the middle of the stars appear to be plotted in different places. The middle of the stars in all rendering modes and the middle of the markers should all coincide at the same x,y co-ordinates. In 1.5.0 they do not.


Return to “Bugs”