AstroNut wrote:Thanks for your help, just call me Brain Dead Bob #2
![Very Happy :D](./images/smilies/icon_biggrin.gif)
![Rolling Eyes :roll:](./images/smilies/icon_rolleyes.gif)
![Wink :wink:](./images/smilies/icon_wink.gif)
AstroNut wrote:Thanks for your help, just call me Brain Dead Bob #2
AstroNut,AstroNut wrote:Vincent:
I was reporting what I thought may be another orbital problem,
not a Lua tools problem. I know that mixing the two may have
caused confusion, but I was more concerned about the reported
position than the Lua tools themselves.
I have installed the Lua tools 1.2 Beta and of course it doesn't show
your position so that point is moot.
Thanks for your help, just call me Brain Dead Bob #2
AstroNut
granthutchison wrote:Chris, the equatorial plane seems to be pretty much the same, as we'd expect since CustomRotation is a good match for UniformRotation at this epoch.chris wrote:Now, the puzzling thing to me is that the CustomRotations are all very close to the old UniformRotations. The positions of Phobos and Deimos will be different, but not dramatically so. The CustomRotations are producing correct correct results, but it seems that equatorial plane for the CustomRotation different than it is for the nearly equivalent UniformRotation.
What has changed is the zero point for orbital longitude within the equatorial plane. As I said above, Celestia used to use the ascending node of the planet's equatorial plane on the celestial equator. Since Horizons provided body-centred elements using the ascending node of the planet's equatorial plane on the ecliptic, we needed to use a planet-specific offset in the longitude of the ascending node to convert from Horizons to Celestia.
The need for this offset has vanished with the introduction of CustomRotation, if Mars is anything to judge by: I now need to use standard Horizons data to position Phobos and Deimos correctly.
Body mean equator and node of date
Reference epoch: "of date"
Reference plane: ICRF/J2000.0 or FK4/B1950.0
xy-plane: central-body mean equator plane at reference epoch
x-axis : out along the ascending node of the central-body mean equator
plane on the reference plane at the reference epoch
z-axis : along the central-body mean north pole at the reference epoch
My first check above was just done by eyeball, but I've now confirmed with some precision. Below is an ssc containing dual definitions for Phobos and Deimos. Those suffixed "Body" use pure Horizons data in EllipticalOrbits tied to the new CustomRotation. Those suffixed "Ecliptic" use pure Horizons data in an Ecliptic2000 OrbitFrame. The positions of the bodies match almost exactly using these definitions, indicating that the loss of our old nodal offset is the origin of the displacement in orbital position when UniformRotation is replaced with CustomRotation.
So I'm guessing you need to be looking at a difference in equatorial node definitions between UniformRotation and CustomRotation.
Yes, you're right, I got it backwards.chris wrote:OK, this all makes sense now. Except, I think that HORIZONS gives body-centered elements using the ascending node of the planet's equatorial plane on the Earth equator of J2000. From the HORIZONS docs:
Code: Select all
BodyFrame { EquatorJ2000 {} }
CustomRotation "iau-mars"
# Overriden by CustomRotation
# UniformRotation
# {
# Period 24.622962
# Inclination 26.72
# AscendingNode 82.91
# MeridianAngle 136.005
# }
Code: Select all
UniformRotation
{
Period 24.622962
Inclination 37.114
AscendingNode 47.681
MeridianAngle 176.868
}
granthutchison wrote:I do share Andrew's concern about the inconsistency arising from the commented-out UniformRotations.
At present, CustomRotations are formally setting some of the planets to an equatorial BodyFrame, while other bodies retain a (non-obvious) ecliptic frame. It strikes me that a completely consistent solution requires us to propagate an "equatorial standard" throughout the solar system, with formal declarations of that BodyFrame for each object, appropriate revisions of the rotation parameters, and revisions of the satellite orbits.
It's a big job, but it would give a much more consistent and transparent final product.
I already have Phobos and Deimos fixed on my local copy, but I haven't committed because I was hoping to plough through the other changes as well. These latter require a degree of care, to make sure they work properly and I don't break anything else.ajtribick wrote:Sounds like a good idea until we come up with a better plan.
Bare minimum is fixing Phobos+Deimos, which is the most urgent task here.
granthutchison wrote:I already have Phobos and Deimos fixed on my local copy, but I haven't committed because I was hoping to plough through the other changes as well. These latter require a degree of care, to make sure they work properly and I don't break anything else.ajtribick wrote:Sounds like a good idea until we come up with a better plan.
Bare minimum is fixing Phobos+Deimos, which is the most urgent task here.
I'm experiencing a few Life Events at present, so I'm making only slow progress. But I can easily commit the bald Phobos/Deimos fix if there is some urgency.
granthutchison wrote:OK. The new Phobos and Deimos orbits have been committed. I've used epoch 2010 to give us reasonable accuracy over the next couple of years.
Grant
It's part of the same problem. With the IAU's choice of north, the period is necessarily negative. With Celestia's choice of north, we don't have negative periods, so the code's not coping very well.ajtribick wrote:The display of the rotation period of Venus as a large negative number of seconds ought to be fixed too.
granthutchison wrote:CustomRotation has also broken Venus.
The original definition for this planet used an "anticlockwise rotation" definition for the north pole, which was a Celestia standard across the data files. The new CustomRotation evidently uses the IAU "north of the ecliptic" definition.
So the planet has been turned upside down. The planetographic grid is the wrong way up (aligned with the inverted textures), and the quoted latitude and longitude values of all features have been flipped N-S and E-W.
Fixing this with the current CustomRotation will require a texture flip for surface and clouds, a revision of the location files, and some recoding for the planetographic grid and how location data are parsed. There are then obvious consistency issues across the other retrograde rotators.
Converting the CustomRotation to Celestia's standard would avoid these extensive knock-on effects, but I've no idea how easy that would be. Chris?
Quick and easy fixes would be simply to restore the original ecliptic UniformRotation, or to set up a new UniformRotation in equatorial coordinates.