Patches that need testing

The place to discuss creating, porting and modifying Celestia's source code.
Topic author
ajtribick
Developer
Posts: 1855
Joined: 11.08.2003
With us: 20 years 10 months

Patches that need testing

Post #1by ajtribick » 04.05.2012, 06:22

Hello everyone,

Here are a few patches submitted to the dev list that could do with some testing:


Would be really useful to have some feedback on these and other patches that are on the dev list!

Avatar
John Van Vliet
Posts: 2940
Joined: 28.08.2002
With us: 21 years 10 months

Re: Patches that need testing

Post #2by John Van Vliet » 04.05.2012, 09:19

--- edit ---
Last edited by John Van Vliet on 19.10.2013, 05:35, edited 1 time in total.

Avatar
John Van Vliet
Posts: 2940
Joined: 28.08.2002
With us: 21 years 10 months

Re: Patches that need testing

Post #3by John Van Vliet » 05.05.2012, 03:30

--- edit ---
Last edited by John Van Vliet on 19.10.2013, 05:35, edited 1 time in total.

Avatar
John Van Vliet
Posts: 2940
Joined: 28.08.2002
With us: 21 years 10 months

Re: Patches that need testing

Post #4by John Van Vliet » 08.05.2012, 09:00

--- edit ---
Last edited by John Van Vliet on 19.10.2013, 05:36, edited 1 time in total.

Topic author
ajtribick
Developer
Posts: 1855
Joined: 11.08.2003
With us: 20 years 10 months

Re: Patches that need testing

Post #5by ajtribick » 09.05.2012, 18:50

Thanks for the testing!

Regarding the output ogv image ratio issue, is that also affecting the other Linux interfaces, or just qt?

Avatar
John Van Vliet
Posts: 2940
Joined: 28.08.2002
With us: 21 years 10 months

Re: Patches that need testing

Post #6by John Van Vliet » 09.05.2012, 21:56

--- edit ---
Last edited by John Van Vliet on 19.10.2013, 05:36, edited 1 time in total.

duds26
Posts: 328
Joined: 05.02.2007
Age: 34
With us: 17 years 4 months
Location: Europe

Re: Patches that need testing

Post #7by duds26 » 11.05.2012, 15:44

After reading the information about the video capture I would say.

- making it work and correctly formatted to be able to read by linux players is something that we really want.

- we can use libtheora on all platforms and if we need to be sure include it and rely as little as possible on platform libraries

- To make it possible for people to watch theora vids in windows + media player (If they are unwilling or incapable of installing a media player of themselves) These are the types that most of them click through an installation without reading anything.
Xiph provides libraries that hook into the platform media components:
For Windows: http://www.xiph.org/dshow/
(directshow filters, could be bundled in installation package, be sure to make the installer uninstall previous versions by default)
For Mac: http://xiph.org/quicktime/
(quicktime components, could be bundled in installation package, be sure to make the installer uninstall previous versions by default)
This solves the issue that most users don't have decent media players.
Last edited by duds26 on 14.04.2018, 18:52, edited 2 times in total.

Topic author
ajtribick
Developer
Posts: 1855
Joined: 11.08.2003
With us: 20 years 10 months

Re: Patches that need testing

Post #8by ajtribick » 12.05.2012, 07:20

The Linux versions already did use libtheora for video capture, and yes the default file extension is indeed ogv. I think the Mac version does as well, but I don't have a Mac to check this.

John Van Vliet has already sent me a pointer to what's causing the aspect ratio issues, will take a look at this soon.

Topic author
ajtribick
Developer
Posts: 1855
Joined: 11.08.2003
With us: 20 years 10 months

Re: Patches that need testing

Post #9by ajtribick » 27.05.2012, 12:28

Looks like the aspect ratio setting wasn't being done properly, took the example from the KDE branch and it is working for me now.

This update is now on trunk, along with the updated preferences window. Will merge this into the 1.7 branch once it is confirmed working.

Avatar
John Van Vliet
Posts: 2940
Joined: 28.08.2002
With us: 21 years 10 months

Re: Patches that need testing

Post #10by John Van Vliet » 27.05.2012, 18:28

--- edit ---
Last edited by John Van Vliet on 19.10.2013, 05:36, edited 1 time in total.

Avatar
John Van Vliet
Posts: 2940
Joined: 28.08.2002
With us: 21 years 10 months

Re: Patches that need testing

Post #11by John Van Vliet » 31.05.2012, 05:02

--- edit ---
Last edited by John Van Vliet on 19.10.2013, 05:34, edited 1 time in total.

ni1s
Posts: 14
Joined: 01.03.2007
With us: 17 years 4 months

Re: Patches that need testing

Post #12by ni1s » 31.05.2012, 12:30

Tested on my Gentoo Linux box and,
ajtribick wrote:
Works,
ajtribick wrote:
  • Updated qt4 preferences window - adds some of the missing preferences functionality to the qt4 version.
  • Also works,
    ajtribick wrote:
  • Autotools improvements (the gcc warnings part of this patch I have already committed to trunk)
  • Didnt test these,
    And also works(duh! :))

    Avatar
    t00fri
    Developer
    Posts: 8772
    Joined: 29.03.2002
    Age: 22
    With us: 22 years 3 months
    Location: Hamburg, Germany

    Re: Patches that need testing

    Post #13by t00fri » 31.05.2012, 13:31

    J.T.K. wrote:Hi,

    Somebody have got ideas to reduce delays :?:

    celestia.Sci :idea:

    Fridger
    Image

    ni1s
    Posts: 14
    Joined: 01.03.2007
    With us: 17 years 4 months

    Re: Patches that need testing

    Post #14by ni1s » 31.05.2012, 14:10

    t00fri wrote:
    J.T.K. wrote:Hi,

    Somebody have got ideas to reduce delays :?:

    celestia.Sci :idea:

    Fridger
    8O What's celestia.sci?

    Avatar
    t00fri
    Developer
    Posts: 8772
    Joined: 29.03.2002
    Age: 22
    With us: 22 years 3 months
    Location: Hamburg, Germany

    Re: Patches that need testing

    Post #15by t00fri » 31.05.2012, 15:42

    ni1s wrote:
    t00fri wrote:
    J.T.K. wrote:Hi,

    Somebody have got ideas to reduce delays :?:

    celestia.Sci :idea:

    Fridger
    8O What's celestia.sci?

    I moved my answer to another place, in order not to sabotage the main subject of this thread!

    Please, see here if you are curious about celestia.Sci
    viewtopic.php?f=2&t=10578&p=129955#p129955
    Image


    Return to “Development”