Another preview - cloud shadows

The place to discuss creating, porting and modifying Celestia's source code.
Avatar
selden
Developer
Posts: 10192
Joined: 04.09.2002
With us: 22 years 2 months
Location: NY, USA

Post #41by selden » 13.07.2006, 21:16

This shot shows some lines that are along 180 west. Are they known? They disappear in a different rendering mode with shadows off.


I see them with medres moving clouds. They seem to be fixed relative to the surface texture and don't move with the clouds. They're also visible when cloud rendering is disabled. My guess would be that they're actually related to the new specularity feature -- perhaps an artifact due to a problem with how the edges of the surface texture and/or specularity maps are handled. Boundary effects are always a pain.
Selden

Avatar
cartrite
Posts: 1978
Joined: 15.09.2005
With us: 19 years 2 months
Location: Pocono Mountains, Pennsylvania, USA Greate Grandfother from Irshava, Zakarpattia Oblast Ukraine

Post #42by cartrite » 13.07.2006, 21:28

Concerning the lines at 180 west,

Chris wrote:
Oops! That was a silly oversight. I just checked in a fix for this problem. If you update the to latest CVS build, the cloud shadows will go away when cloud maps are disabled.

The cvs version I'm using is about an hour and a half old now. Chris stated earlier that he commited a fix for shadows that didn't disappear after clouds were toggled off. You may have the older version were the shadows remained? My version turns the lines off when the clouds are toggled off even in OpenGL. Or the rendering mode changes and the clouds are on.
VivoBook_ASUSLaptop X712JA_S712JA Intel(R) UHD Graphics 8gb ram. Intel(R) Core(TM) i5-1035G1 CPU @ 1.00GHz, 1190 Mhz, 4 Core(s), 8 Logical Processor(s) 8 GB ram. Running on Windows 11 and OpenSuse 15.4

Avatar
cartrite
Posts: 1978
Joined: 15.09.2005
With us: 19 years 2 months
Location: Pocono Mountains, Pennsylvania, USA Greate Grandfother from Irshava, Zakarpattia Oblast Ukraine

Post #43by cartrite » 13.07.2006, 21:45

I just turned on the cloudspeed. And your right Selden. The lines are in a fixed position relative to the cloud movement. But there is a shift to the left or right (depending on time forward or backward) as the specular highlight pases over the area. If that means anything to anyone.

cartrite
VivoBook_ASUSLaptop X712JA_S712JA Intel(R) UHD Graphics 8gb ram. Intel(R) Core(TM) i5-1035G1 CPU @ 1.00GHz, 1190 Mhz, 4 Core(s), 8 Logical Processor(s) 8 GB ram. Running on Windows 11 and OpenSuse 15.4

Topic author
chris
Site Admin
Posts: 4211
Joined: 28.01.2002
With us: 22 years 9 months
Location: Seattle, Washington, USA

Post #44by chris » 13.07.2006, 21:49

selden wrote:
This shot shows some lines that are along 180 west. Are they known? They disappear in a different rendering mode with shadows off.

I see them with medres moving clouds. They seem to be fixed relative to the surface texture and don't move with the clouds. They're also visible when cloud rendering is disabled. My guess would be that they're actually related to the new specularity feature -- perhaps an artifact due to a problem with how the edges of the surface texture and/or specularity maps are handled. Boundary effects are always a pain.


It's related to cloud shadows, not the new per pixel specular lighting. Cloud shadows involve rectangular to spherical coordinate transformation, which means that the vertex shader uses an arctangent function. The discontinuity in arctangent results in the line along the 180 meridian. I'm working on a fix.

--Chris

Avatar
Chuft-Captain
Posts: 1779
Joined: 18.12.2005
With us: 18 years 11 months

Post #45by Chuft-Captain » 14.07.2006, 00:17

chris wrote:
Chuft-Captain wrote:
chris wrote:I should have put that on the list too. I recently fixed one depth sorting bug that Selden had alerted me about. But, if you're talking about depth sorting of transparent objects, that's a ways off.
I'm happy to wait for as long as it takes if it's still high on your list of priorities. (Actually I've no choice in the matter as I'm not in a position to fix these bugs myself :wink: )
JOOI: What's the technical hurdle that makes the transparent depth-sorting more difficult to fix than Selden's bug?
It's a fundamental limitation of all currently shipping graphics hardware. In order for translucent objects to be rendered correctly, the triangles must be sorted so that the ones furthest from the viewer are rendered first. You can do the sorting on the CPU, but for a moderately detailed model this will be very slow. There are no practical workarounds that completely solve the problem. Only partial fixes exist.
OK, that makes sense. Thanks for the explanation.
Damn!

Chris wrote:
Chuft-Captain wrote:Secondly, to which category do the problems I reported to you earlier in the year belong to? (Do you remember those?)
Do you think those problems will be resolved by the bug-fix you mention above, or are they in the category of transparent object depth sorting bugs?

I'll have to look at your bug report again; there's a good chance that if it didn't involve translucent models, your problem may have been fixed by my change.
I think this was in a PM to you. (I can resend if you can't find it). My problems DID involve models with transluscent parts, however the DS problems occurred between opaque surfaces of the model.

Chris wrote:
Chuft-Captain wrote:BTW. Do you have any rough gut feeling for the likely "performance hit" of solving the DS problems as compared to the performance hit of the rendering improvements in your recent threads? Is it likely to be more or less of a performance drag than these other improvements?

It's a more complicated discussion than I have time for right now :) But I do have a very good understanding of all the performance implications.
That's OK. I'm sure your time is better spent coding, than discussing. I would assume that it's not orders of magnitude more costly than the other changes anyway. :wink:

PM me if you need me to resend that bug report.
Cheers
"Is a planetary surface the right place for an expanding technological civilization?"
-- Gerard K. O'Neill (1969)

CATALOG SYNTAX HIGHLIGHTING TOOLS LAGRANGE POINTS

Avatar
fsgregs
Posts: 1307
Joined: 07.10.2002
With us: 22 years 1 month
Location: Manassas, VA

Post #46by fsgregs » 21.07.2006, 03:21

Chris:

Just a short note. The cloud shadows look great.

Edited: I just found the answer to my question originally posted here about including shadows being cast on spacecraft by planets below. Thanks for planning to include it in the next pre-release.

:D

Frank

Avatar
Cham M
Posts: 4324
Joined: 14.01.2004
Age: 60
With us: 20 years 10 months
Location: Montreal

Post #47by Cham » 24.09.2006, 17:48

How do I turn ON cloud shadows, with Celestia 1.5.0 ? And what is the SSC commands for Cloud bump maps ?

In the atmosphere code, I tried "CloudShadows true", "CloudShadow true", "Cloudshadows true" and "Cloudshadow true", none worked.
"Well! I've often seen a cat without a grin", thought Alice; "but a grin without a cat! It's the most curious thing I ever saw in all my life!"

Avatar
selden
Developer
Posts: 10192
Joined: 04.09.2002
With us: 22 years 2 months
Location: NY, USA

Post #48by selden » 24.09.2006, 17:59

Cloudshadows are supposed to be always on. There is no SSC control over them.

Unfortunately, it looks like they've stopped working. :(
Selden

Avatar
Cham M
Posts: 4324
Joined: 14.01.2004
Age: 60
With us: 20 years 10 months
Location: Montreal

Post #49by Cham » 24.09.2006, 18:01

Selden,

are the shadows "broken" on your system too ?

and what about bumps ?
"Well! I've often seen a cat without a grin", thought Alice; "but a grin without a cat! It's the most curious thing I ever saw in all my life!"

Avatar
selden
Developer
Posts: 10192
Joined: 04.09.2002
With us: 22 years 2 months
Location: NY, USA

Post #50by selden » 24.09.2006, 18:02

And there are no cloud bumpmaps, only
CloudNormalMap
Selden

Avatar
Cham M
Posts: 4324
Joined: 14.01.2004
Age: 60
With us: 20 years 10 months
Location: Montreal

Post #51by Cham » 24.09.2006, 18:03

Where can I find a CloudnormalMap file, so I can test it ? I'm unable to create one yet.

Please, be precise : are the shadows broken for you too ?
"Well! I've often seen a cat without a grin", thought Alice; "but a grin without a cat! It's the most curious thing I ever saw in all my life!"

Avatar
t00fri
Developer
Posts: 8772
Joined: 29.03.2002
Age: 22
With us: 22 years 7 months
Location: Hamburg, Germany

Post #52by t00fri » 24.09.2006, 18:04

Cham wrote:How do I turn ON cloud shadows, with Celestia 1.5.0 ? And what is the SSC commands for Cloud bump maps ?

In the atmosphere code, I tried "CloudShadows true", "CloudShadow true", "Cloudshadows true" and "Cloudshadow true", none worked.


You first got to assign a key via a celx script like so

Code: Select all

-- start.celx

function slowgoto()
    sel = celestia:getselection()
    obs = celestia:getobserver()
    if sel and obs then
        obs:goto(sel, 15)
    end
end

function togglecloudshadows()
    t = celestia:getrenderflags()
    t2 = {}
    t2.cloudshadows = not t.cloudshadows;
    celestia:setrenderflags(t2);
end

keyhandlers =
{
   G = slowgoto,
   V = togglecloudshadows,
}

function handlekey(k)
    handler = keyhandlers[k.char]
    if (handler ~= nil) then
        handler()
        return true
    else
        return false
    end
end

celestia:registereventhandler("key", handlekey)

-- end


Once you run that script (e.g. by making start.celx the default startup script in celestia.cfg, then you toggle the cloud shadows by pushing SHIFT+V.

There is also a slowgoto binding which you may try out.
It's simple, isn't it ;-)

Oh yes: note cloudshadows ONLY work in the OpenGL 2.0 path!


Bye Fridger

PS: Note the cloudshadows still produce artefacts (bands in a certain distance...)
So don't report these. We know that already ;-)
Last edited by t00fri on 24.09.2006, 18:09, edited 1 time in total.
Image

Avatar
selden
Developer
Posts: 10192
Joined: 04.09.2002
With us: 22 years 2 months
Location: NY, USA

Post #53by selden » 24.09.2006, 18:07

Correct: cloud shadows aren't visible on my system. Some recent code change must have broken them.
Selden

Avatar
selden
Developer
Posts: 10192
Joined: 04.09.2002
With us: 22 years 2 months
Location: NY, USA

Post #54by selden » 24.09.2006, 18:09

Fridger,

Then something has changed.
It was the case that cloud shadows were on by default. I've never had to toggle them before.

*sigh*

It'll take me a while to test your script.

s.
Selden

Avatar
t00fri
Developer
Posts: 8772
Joined: 29.03.2002
Age: 22
With us: 22 years 7 months
Location: Hamburg, Germany

Post #55by t00fri » 24.09.2006, 18:12

selden wrote:Fridger,

Then something has changed.
It was the case that cloud shadows were on by default. I've never had to toggle them before.

*sigh*

It'll take me a while to test your script.

s.

Here is what Chris wrote already in march:
(Dev list)
This morning I checked in a change that adds a new render flag for
cloud shadows. This flag is off by default, so you'll no longer see
cloud shadows when you start up Celestia. At the moment, there's no
way to turn them on via the UI. I think we've exhausted all the
keyboard bindings, and I'm not sure it that toggling cloud shadows
deserves it's own key binding anyhow. You can turn on cloud shadows
with a celx script, however.


Bye Fridger
Image

Avatar
Cham M
Posts: 4324
Joined: 14.01.2004
Age: 60
With us: 20 years 10 months
Location: Montreal

Post #56by Cham » 24.09.2006, 18:13

I just tried the script. The slowGo option works (I'm not sure it will be usefull, however).

And the cloudshadow doesn't work properly. I get some color garbages around the screen, the ocean becomes deep blue, and no shadows. :-(
"Well! I've often seen a cat without a grin", thought Alice; "but a grin without a cat! It's the most curious thing I ever saw in all my life!"

Avatar
selden
Developer
Posts: 10192
Joined: 04.09.2002
With us: 22 years 2 months
Location: NY, USA

Post #57by selden » 24.09.2006, 18:16

Fridger,

Thanks for the reminder. I now vaguely do recall that posting. I guess my assumption was that the toggle would show up soon in the GUI menu (it hasn't) , so I just forgot about it :(

Cham,

Fridger's CELX script works fine. Copy it to a .CELX file, double click on its icon, and then cloud shadows will toggle on and off when you type a Capital-V.
Selden

Avatar
t00fri
Developer
Posts: 8772
Joined: 29.03.2002
Age: 22
With us: 22 years 7 months
Location: Hamburg, Germany

Post #58by t00fri » 24.09.2006, 18:16

fsgregs wrote:Chris:

Just a short note. The cloud shadows look great.

Edited: I just found the answer to my question originally posted here about including shadows being cast on spacecraft by planets below. Thanks for planning to include it in the next pre-release.

:D

Frank


Sorry, Frank,

I am not Chris, but I'll answer nevertheless ;-)

Personally, I am a bit surprised that you find the present cloud shadows so nice. There are SERIOUS artefacts (that Chris is aware of) repeating in a certain distance. They get increasingly disturbing the higher the resolution.

Didn't you spot these?

Next, I think with the /present/ cloud textures, the cloud shadows look pretty unnatural! So did you make new, appropriate cloud textures already? Let me know...

Bye Fridger
Image

Avatar
Cham M
Posts: 4324
Joined: 14.01.2004
Age: 60
With us: 20 years 10 months
Location: Montreal

Post #59by Cham » 24.09.2006, 18:19

selden wrote:Fridger's CELX script works fine. Copy it to a .CELX file, double click on its icon, and then cloud shadows will toggle on and off when you type a Capital-V.


I know it works, I've tried it (the slowGo option works). But the capital-V gives me some colorfull garbage around the window, the oceans becomes dark ("deep blue"), and no shadows. And Celestia becomes very slooooow !
"Well! I've often seen a cat without a grin", thought Alice; "but a grin without a cat! It's the most curious thing I ever saw in all my life!"

Avatar
t00fri
Developer
Posts: 8772
Joined: 29.03.2002
Age: 22
With us: 22 years 7 months
Location: Hamburg, Germany

Post #60by t00fri » 24.09.2006, 18:19

Cham wrote:I just tried the script. The slowGo option works (I'm not sure it will be usefull, however).

And the cloudshadow doesn't work properly. I get some color garbages around the screen, the ocean becomes deep blue, and no shadows. :-(


Did you switch on the OpenGL 2.0 render path???

The script certainly works for me since JULY 2006!

Bye Fridger
Image


Return to “Development”