LUAPLUGINS: Distance Calculator

[jogad]

Hi

I have found a serious bug in this plugin.

Code: Select all

plugins =
   {
      -- "compassBox",
      "KeplerParamBox",
      "coordinateBox",
      "pictureBox",
      "HRBox",
      "distance_calc",    <- string to add
   }


If you run the Lua Plug-ins without the compass, it doesn't work at all!

Your plugin should not rely on another tool to work.
This is very likely why it doesn't work with Lua Edu Tools.
It is a pity because the litte toolbar that you are using is designed to make plugins that work automatically with both Lua Plug-ins and Lua Edu tools.

[Fenerit]

If you run the Lua Plug-ins without the compass, it doesn't work at all!

I do not recognize this bug. On my system all works fine even though the "compassBox.lua" is commented out; both whether the "distance_calc" is placed as subfolder of .."extras/" or as subfolder of "..extras/lua_plugins/". The only library it does use is the "celutil.lua"; thus whether placed as subfolder of "..extras/" it would use that of luatools or plugins either (if specified). As subfolder of "../lua_plugins" such a library can be unspecified as "require" due to the path root; while as subfolder of "..extras/", yes (for the Luatools, tough). This is the difference amongst luatools and luaplugins about external modules, like you can see with the CMODtracer, that works also from Luatools and in which such library has been forcely specified. The why this plugin doesn't work on Luatools must be another question respect to such library.

P.S.
I do not think that plug-ins must not rely on pre-existent library: this should be a limitation for more complex plugins; being LUA an interpreted language and not a compiled language.

EDIT LATER:
If both lua_edu_tools and lua_plugins are present in "../extras" they can do conflict even though just one hook only is specified; must be place an underscore on the folders to avoid them (i.e ../extras/_lua_edu_tools/" or ../extras/_lua_plug_ins/".

[Fenerit]

Info: I find a bug with "coordinateBox" commented out, tough!

[Chuft-Captain]

Code: Select all

"distance_calc",    <- string to add

-->

Code: Select all

"distance_calc",    -- <- string to add

[Fenerit]

Wait... I'm arriving... @echo..Brz$$$$$$REM@@fail$$$success!!!|@ECHO OFF
prompt $p$g...kfgtreyhf@@@@STACKover??$flow

[Chuft-Captain]

Wait... I'm arriving... @echo..Brz$$$$$$REM@@fail$$$success!!!|@ECHO OFF
prompt $p$g...kfgtreyhf@@@@STACKover??$flow

WTF ?!

[symaski62]

distance

[Fenerit]

LOCAL!

Distance calculator v. 1.0 (see first post)

Thanks to Jo?l now this plugin is fully functional also for LUA EDU TOOLS. Jo?l has corrected all bugs in my fault code, from which its ergonomics result changed, thus the original "one-shot" button and the colors shift have been recovered. Now this latter follows the illuminated fraction of the object (aside stars) instead of its phase angle; this feature makes the color' shift more coehrent with the toggling through the poles. Moreover, if I've well understood the symaski62's remarks, the distance is now calculated for objects radii which are in the order of meters (spacecrafts).

distance_calc_1.0.jpg

[jogad]

Hi,

Jo?l has corrected all bugs in my fault code

I fear it is not true

I you click the button when a DSO is selected, it crashes !
It is possible to make it work for DSO too, but I think it is not relevant.
I propose a fix to prevent making measures on galaxies, globulars and so on...

Code: Select all

distance_calc_function[1] = function()
   celestia:setrenderflags{markers = true};
   refObj = nil
   long1 = nil
   celestia:unmarkall();
   local sel = celestia:getselection()
   if not empty(sel) then
      if sel:type() == "location" then
         sel:mark(StartMarkerColor, StartMarkerSymbol, StartMarkerSize, StartMarkerOpacity, "", false);
         local obsposition = obs:getposition()
         obs:setposition(sel:getposition())
         refObj = sel:getinfo().parent
         long1, lat1 = celutil.get_long_lat(obs, refObj)
         obs:setposition(obsposition)
      else
         refObj = sel
      end
   else
      refObj = obs:getframe():getrefobject()
   end
   if refObj then
      if refObj:getinfo().parent or refObj:type() == "star" then
         celestia:select(refObj)
         obs:follow(refObj)
         if not long1 then
            long1,lat1 = celutil.get_long_lat(obs, refObj)
         end
         refObj:mark(CalcMarkerColor, CalcMarkerSymbol, CalcMarkerSize, CalcMarkerOpacity, "", false);
      else
         refObj = nil
      end
   end
end;


As I am playing with this tool, I think it would be cool if we can have the starting point marker even if it is not a location.
I think it is possible with a fake object.

[Fenerit]

Hi,

I fear it is not true

I you click the button when a DSO is selected, it crashes !
It is possible to make it work for DSO too, but I think it is not relevant.

Ops!.. I didn't noticed that. The link has been updated.

[Fenerit]

Distance calculator v. 1.1 (see first post)

Minor fixes:

- fixed the displacement of the button when Celestia is resized in windowed mode. Now the button remains where is.
- fixed the time delay when the plugin exit. Now the restored time does account for the time spent in measuring.