Page 1 of 1

not POSIX compliant test(1) usage in configure.in

Posted: 07.05.2003, 18:19
by salo
there are several places in configure.in (and in configure script generated from the former) where test(1) utility is used in a way which breaks POSIX compliant test(1). POSIX (http://www.opengroup.org/onlinepubs/007904975/utilities/test.html) requires test(1) to use single = for string comparisions yet celestia's configure.in uses ==, which results in breaks on systems which don't use bash(1) as a /bin/sh (e.g. *BSD or SVr4 systems).

here is the patch for 1.3.0 release: http://Xtrmntr.org/salo/celestia-1.3.0-configure.in.diff

Posted: 07.05.2003, 20:19
by Christophe
I've commited your patch, thanks for taking the time to provide it.

Posted: 07.05.2003, 20:24
by salo
you're welcome. i discovered this issue while working on (soon to be committed) celestia packages for NetBSD. thanks for the fast reply.