Celestia Forums

Hello

I've noticed that labels and markers for 3 locations on Io (Apis Tholus, Inachus Tholus and Tsui Goab Tholus) are visible only when "Other features" in "Locations" menu are disabled. Enabling "Other features" cause these labels and markers to vanish. I guess it's related to the type of these locations, which is "TH".

I've found the problem in Celestia r4602

Paul

EDIT:

There are even more locations of the same type - "TH" on Mars and there is the same problem with them (for example with Apollinaris Tholus).

Paul,

I could reproduce this issue and I've got a fix for it. Actually, the 'Tholus' location type was missing from the
LocationFlagMap in celx.cpp. I guess that you're using the Lua Tools or some other celx script that deals with
location labels. That's why the behaviour of the 'other features' check box was inverted for 'Tholus' type locations.

The following change fixes that:


Please let me know if it also fixes the issue on your system. Thanks for the bug report.

Vincent,

Vincent wrote:I could reproduce this issue and I've got a fix for it. Actually, the 'Tholus' location type was missing from the
LocationFlagMap in celx.cpp.

Thank you for fixing the bug.

Vincent wrote:I guess that you're using the Lua Tools or some other celx script that deals with
location labels.

That's right. I'm using the Lua Edu 1.2 Tools.

Vincent wrote:Please let me know if it also fixes the issue on your system.

Unfortunatelly, I've never compiled Celestia on my own and I just don't know how to do it.
I could easily download the file celx.cpp from SVN and then modify it according to the code in your last post, but I have no idea what to do to compile Celestia and produce the executable file.

Paul

SU(3)xSU(2)xU(1) wrote:Thank you for fixing the bug.

Paul, you're welcome.

SU(3)xSU(2)xU(1) wrote:That's right. I'm using the Lua Edu 1.2 Tools.

The Lua Tools are, at least, a very powerful tool for tracking celx/Lua bugs.

SU(3)xSU(2)xU(1) wrote:Unfortunatelly, I've never compiled Celestia on my own and I just don't know how to do it.

No problem, here's a link to an executable file that includes the above change:
http://vincent.giangiulio.perso.sfr.fr/ ... lestia.exe

Vincent wrote:No problem, here's a link to an executable file that includes the above change:
http://vincent.giangiulio.perso.sfr.fr/ ... lestia.exe

Hey, thanks for that, Vincent. This Brain-Dead user got it too, so thanks.
I hope you don't mind.

Vincent wrote:No problem, here's a link to an executable file that includes the above change:
http://vincent.giangiulio.perso.sfr.fr/ ... lestia.exe

Vincent,

Thank you very much.

Unfortunately I cannot open Celestia with this executable. I get the error message about the lack of "libpng1.dll"

Paul

SU(3)xSU(2)xU(1) wrote:Unfortunately I cannot open Celestia with this executable. I get the error message about the lack of "libpng1.dll"

The following zip files also includes all the needed dll's. It should work now.
http://vincent.giangiulio.perso.sfr.fr/ ... lestia.zip

BobHegwood wrote:Hey, thanks for that, Vincent. This Brain-Dead user got it too, so thanks.
I hope you don't mind.

Bob,

Of course, I don't. I'm happy you find it useful.

Vincent,

Thanks once again.

I can confirm, that the bug is really fixed (at least on Win XP)

I have also a qestion about your executable. Why it has only 2,07 MB instead of 3,42 MB (the size of r4602 executable - Cartrite's built)? Moreover, in properties of this file it is also written that this is version 1.5.0.0 and not for example 1.6.0.4604. However this executable, after running it, seems to have all properties of the latest SVN. Could you explain it?

Paul

The size suggests that Vincent did not include SPICE support.

selden wrote:The size suggests that Vincent did not include SPICE support.

Selden,

Thank you for the explanation.

Paul

The fix is in SVN now.

selden wrote:The size suggests that Vincent did not include SPICE support.

Selden is right, I don't build Celestia with SPICE support.

Unfortunately, I've found exactly the same kind of bug for "Mayda Insula" on Titan.

I should have checked earlier wether "tholus" was the only kind of location, which was affected. I hope, that there are no more such location types except for "insula", but I'm not sure...

Paul

SU(3)xSU(2)xU(1) wrote:Unfortunately, I've found exactly the same kind of bug for "Mayda Insula" on Titan.

I should have checked earlier wether "tholus" was the only kind of location, which was affected. I hope, that there are no more such location types except for "insula", but I'm not sure...

Paul,

Thanks for tracking this once again. I'll commit the fix soon.
This was for sure the last location type missing in celx. I've checked
this out by comparing the list in location.cpp with the one in celx.cpp:

Vincent wrote:

SU(3)xSU(2)xU(1) wrote:Unfortunately, I've found exactly the same kind of bug for "Mayda Insula" on Titan.

I should have checked earlier wether "tholus" was the only kind of location, which was affected. I hope, that there are no more such location types except for "insula", but I'm not sure...

Paul,

Thanks for tracking this once again. I'll commit the fix soon.
This was for sure the last location type missing in celx. I've checked
this out by comparing the list in location.cpp with the one in celx.cpp:

Vincent,

Thank you very much for the response and for commiting the fix in SVN.

Paul

SU(3)xSU(2)xU(1) wrote:Vincent,

Thank you very much for the response and for commiting the fix in SVN.

Paul,

You're welcome. The fix is in SVN now.