Celestia Forums

Is it just me or build from latest CVS shows red orbit line by default for any selected/followed object

Boux wrote:Is it just me or build from latest CVS shows red orbit line by default for any selected/followed object

Same for me.

F.

I think the red orbit line when you select it, was implemented several months (or 1-2 year ?) ago but I am sure it was available in Celestia 1.3.2. Don't worry, it is normal

Fightspit wrote:I think the red orbit line when you select it, was implemented several months (or 1-2 year ?) ago but I am sure it was available in Celestia 1.3.2. Don't worry, it is normal

Fightspit,

The problem is that the orbit line remains displayed even when the orbits rendering is disabled (with the [O] key).

I also noticed that the fps is noticeably higher than with the previous builds when viewing complex scenes with hi-polys models.
I am wondering whether this has something to do with Chris' on-going work on improved depth sorting.
I may be wrong, but it seems that rendering is different with some objects. The Barzan wormhole for example looks much better when seen sideways.

EDIT:
Oh yeah!
The answer is there:

Commit by Chris-----------------------------------------------
Update of /cvsroot/celestia/celestia/src/celengine
In directory sc8-pr-cvs4.sourceforge.net:/tmp/cvs-serv8076

Modified Files:
render.cpp render.h
Log Message:
- Replaced the old depth sorting algorithm with a new, cleaner, faster, and more robust
scheme.
- Overhauled orbit path rendering so that orbit paths get correctly depth sorted
-------------------------------------------------------------------
That's cool

There seems to be another bug concerning the orbit line : it is not drawn entirely at a certain angle/distance from the selected object. Here's a Cel URL. Once Celestia opened, you can try to reproduce the bug by changing the distance from the Earth.

cel://Follow/Earth/2006-09-09T10:20:10. ... 9&lm=-2046

Don't forget that the line is not drawn past the point where it would be coming out of the screen. (That's called "near plane clipping".)

I suspect (but I'm not sure) that the end of the line that you see is where it would be penetrating the screen of your display. That always seems to be what is happening when I find a viewpoint where the orbital path seems to be incomplete. If we had real 3D displays, it'd be coming out of the screen and going over our shoulders!

Can you generate a URL while running the cvs version of Celestia that shows the truncation of the line when it would not be intersecting with the screen?

Here's one that's obviously due to near plane clipping. The slightest movement of the viewpoint causes the end of the line segment to jump all over the screen because of the viewing angle.

near plane clipping

Sorry, but this URL only works for the current cvs code.


.

Selden,

I think you're right as for the "near plane clipping" phenomenom.
But there's still a problem to me : from the cel URL I've posted, please try to move farther from the Earth, pressing continuously the [END] key for about 5 seconds. The Earth and its orbit should suddenly disappear entirely, and then reappear...

Vincent wrote:Selden,

I think you're right as for the "near plane clipping" phenomenom.
But there's still a problem to me : from the cel URL I've posted, please try to move farther from the Earth, pressing continuously the [END] key for about 5 seconds. The Earth and its orbit should suddenly disappear entirely, and then reappear...

i've noticed this too.
also trying the magnetic-earth-addon with the new depth-sorting makes all lines rendered behind earth.

phoenix wrote:also trying the magnetic-earth-addon with the new depth-sorting makes all lines rendered behind earth.

Does the lines behaves the same, as seen from some distance ? On version 1.4.1, the field lines are drawn correctly if I'm sitting far away from the Magnetic Earth. If I get closer, the lines disappears behind Earth.

Cham wrote:

phoenix wrote:also trying the magnetic-earth-addon with the new depth-sorting makes all lines rendered behind earth.

Does the lines behaves the same, as seen from some distance ? On version 1.4.1, the field lines are drawn correctly if I'm sitting far away from the Magnetic Earth. If I get closer, the lines disappears behind Earth.

all the lines rendered perfect for me until chris added the new depth-sorting code a few days ago.
I don't see any difference between close-up view or far distance

Vincent wrote:

Fightspit wrote:I think the red orbit line when you select it, was implemented several months (or 1-2 year ?) ago but I am sure it was available in Celestia 1.3.2. Don't worry, it is normal

Fightspit,

The problem is that the orbit line remains displayed even when the orbits rendering is disabled (with the [O] key).

I just checked in a fix. It was an easy one--a required pair of parentheses were missing

My change also enables selection highlighting for star orbit paths.

--Chris

Vincent wrote:Selden,

I think you're right as for the "near plane clipping" phenomenom.
But there's still a problem to me : from the cel URL I've posted, please try to move farther from the Earth, pressing continuously the [END] key for about 5 seconds. The Earth and its orbit should suddenly disappear entirely, and then reappear...

The bug that made the Earth (and maybe all other bodies) suddenly disappear and reappear when moving farther from it seems to have... disappeared in the latest CVS version.

yes confirmed.
it was fixed in CVS tonight... I read something about depth-sorting of comets was not accounted for yet

chris wrote:

Vincent wrote:

Fightspit wrote:I think the red orbit line when you select it, was implemented several months (or 1-2 year ?) ago but I am sure it was available in Celestia 1.3.2. Don't worry, it is normal

Fightspit,

The problem is that the orbit line remains displayed even when the orbits rendering is disabled (with the [O] key).

I just checked in a fix. It was an easy one--a required pair of parentheses were missing

My change also enables selection highlighting for star orbit paths.

--Chris

Beuuhh, my fresh build (two minutes ago) still give me the red orbit... osX problem or else?

This may be a related bug...

When I select a non-planet (Sedna for example) and I have orbits being
displayed, the bright red orbit is a nice feature, especially if you're trying
to show where the selected object's orbit should be.

On to the bug...

When I select Sedna and tell Celestia to GOTO it, the object itself seems
to be drawn far AWAY from the nice red orbit. Has this been a problem in
the past? As Celestia takes me to the object, I'm taken past the red
orbit prior to getting to the object which is always far away from the red
orbit itself.

Never noticed it with planets, but with non-planets the objects are always
located somewhere OUTSIDE of the nice red orbit.

Just FYI.

Thanks, Bob

I don't think what you mean is a bug.
try increasing the OrbitPathSamplePoints to 500 or even 1000.

the bigger the radius of the orbit and the smaller the radius of the object the more will their path differ.
this problem exists since celestia was created.

phoenix wrote:I don't think what you mean is a bug.
try increasing the OrbitPathSamplePoints to 500 or even 1000.

the bigger the radius of the orbit and the smaller the radius of the object the more will their path differ.
this problem exists since celestia was created.

Ah... I see what you mean.

Thanks very much for the reply here. I didn't understand that this problem
existed because it did not occur with the planetary orbits. I do see what you
mean with the relatively small orbiting bodies though.

Again, I appreciate the advice.