Celestia 1.4.0 build fails on Fedora Core 5 test 2

[steve]

I'm working on the Fedora Extras celestia package. The build (configured with --with-gnome) fails here:

if g++ -DHAVE_CONFIG_H -I. -I. -I../.. -I.. -Wnon-virtual-dtor -Wno-long-long -Wundef -ansi -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -Wcast-align -Wconversion -Wchar-subscripts -Wall -W -Wpointer-arith -Wwrite-strings -DNDEBUG -DNO_DEBUG -O2 -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=nocona -Wformat-security -Wmissing-format-attribute -fno-exceptions -fno-check-new -fno-common -O2 -Wall -ffast-math -fexpensive-optimizations -fomit-frame-pointer -DORBIT2=1 -pthread -I/usr/include/libgnomeui-2.0 -I/usr/include/libgnome-2.0 -I/usr/include/libgnomecanvas-2.0 -I/usr/include/gtk-2.0 -I/usr/include/libart-2.0 -I/usr/include/gconf/2 -I/usr/include/libbonoboui-2.0 -I/usr/include/gnome-vfs-2.0 -I/usr/lib64/gnome-vfs-2.0/include -I/usr/include/gnome-keyring-1 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/orbit-2.0 -I/usr/include/libbonobo-2.0 -I/usr/include/bonobo-activation-2.0 -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/lib64/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/libxml2 -I/usr/include/gtkglext-1.0 -I/usr/lib64/gtkglext-1.0/include -MT boundaries.o -MD -MP -MF ".deps/boundaries.Tpo" \
-c -o boundaries.o `test -f 'boundaries.cpp' || echo './'`boundaries.cpp; \
then mv -f ".deps/boundaries.Tpo" ".deps/boundaries.Po"; \
else rm -f ".deps/boundaries.Tpo"; exit 1; \
fi
astro.cpp:176: warning: unused parameter 'spherePos'
astro.cpp:176: warning: unused parameter 'viewerPos'
../celengine/model.h:73: warning: 'class Model::MeshComparator' has virtual functions but non-virtual destructor
../celengine/model.h:91: warning: 'class Model::OpacityComparator' has virtual functions but non-virtual destructor
../celengine/orbit.h:19: warning: 'class Orbit' has virtual functions but non-virtual destructor
../celengine/orbit.h:35: warning: 'class EllipticalOrbit' has virtual functions but non-virtual destructor
../celengine/orbit.h:62: warning: 'class OrbitSampleProc' has virtual functions but non-virtual destructor
../celengine/orbit.h:77: warning: 'class CachingOrbit' has virtual functions but non-virtual destructor
../celengine/star.h:33: error: extra qualification 'StarDetails::' on member 'StarDetails'
body.cpp: In member function 'void Body::setName(std::string)':
body.cpp:76: error: 'gettext' was not declared in this scope

[John Van Vliet]

i do belive that gcc 4.0.2 is the prob
the cvs code builds for me with fedore4 and gcc4
also the celestia code dose nead a clean up very badly

[steve]

FWIW, the FC5 Extras package is going to be based on Celestia from CVS plus this little patch:
http://cvs.fedora.redhat.com/viewcvs/rpms/celestia/devel/celestia-1.4.0-compile.patch?root=extras&view=markup

It compiles anyway. Now I have to do some testing...

[RocketMan@JSC]

FWIW, the FC5 Extras package is going to be based on Celestia from CVS plus this little patch:
http://cvs.fedora.redhat.com/viewcvs/rpms/celestia/devel/celestia-1.4.0-compile.patch?root=extras&view=markup

It compiles anyway. Now I have to do some testing...

^^ That works for me! How nice to even have an rpm, even though it's just a few lines.

Scott

[John Van Vliet]

hi with gcc 4.1 line 33 in star.h neads to beedited and line 100 in command.h has the same problem .Boath files are in /src/celengine

oops -- i just checked cvs and this has been fixed
but 1.4 still neades it

[/code]