Eclipse Finder Crash

Report bugs, bug fixes and workarounds here.
Topic author
Nerull

Eclipse Finder Crash

Post #1by Nerull » 22.03.2004, 04:34

If you search for an eclipse, and there are no results, if you click 'None', and hit 'Go to time and planet' Celestia crashes.

Heres how i found it:
Eclipse Finder
Saturn - 22 Feb 2003 to 22 Mar 2005
Click None, hit Go to time and planet'...boom, crash.

Ive tested it with other planets as well, same result.

WinXP
Athlon XP 1800+
Geforce FX

Topic author
Nerull

Post #2by Nerull » 22.03.2004, 04:45

This is with 1.3.2-pre7

Avatar
Joe
Posts: 162
Joined: 29.02.2004
With us: 20 years 8 months
Location: United Kingdom

Post #3by Joe » 24.03.2004, 16:35

I would think this is a small bug in the source code file:- eclipsefinder.cpp

Code: Select all

Eclipse::Eclipse(int Y, int M, int D)
{
    date = new astro::Date(Y, M, D);
}

Eclipse::Eclipse(double JD)
{
    date = new astro::Date(JD);
}


The two constructor should initialise data member:-body

like this?

Code: Select all

Eclipse::Eclipse(int Y, int M, int D) : body(NULL)
{
    date = new astro::Date(Y, M, D);
}

Eclipse::Eclipse(double JD) : body(NULL)
{
    date = new astro::Date(JD);
}


It did work on my XP machine
Joe
8O

chris
Site Admin
Posts: 4211
Joined: 28.01.2002
With us: 22 years 9 months
Location: Seattle, Washington, USA

Post #4by chris » 24.03.2004, 17:00

Thanks Joe--that is indeed the fix! I've checked it into CVS.

--Chris


Return to “Bugs”